fix(mmmu_pro_vision): apply post_prompt to vision-only split#1336
Merged
kcz358 merged 1 commit intoMay 20, 2026
Merged
Conversation
kcz358
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
mmmu_pro_doc_to_textreturns an empty string formmmu_pro_vision: the vision split has noquestionfield, so the standard prompt-construction branch is skipped and the YAML-configuredpost_prompt("Answer with the option letter from the given choices directly.") is never sent to the model.Fix
Default
questiontopost_promptso the instruction reaches the model for vision-only docs. Standard split behavior is unchanged.