fix(mmvp): apply ground truth corrections in code for robust evaluation - #1495
Open
lorenzozanee wants to merge 1 commit into
Open
fix(mmvp): apply ground truth corrections in code for robust evaluation#1495lorenzozanee wants to merge 1 commit into
lorenzozanee wants to merge 1 commit into
Conversation
Apply the four verified corrections (indices 99, 100, 279, 280) for the MMVP elephant-tusks and person-posture pairs in mmvp_doc_to_target and mmvp_process_results. The fix is idempotent with the lmms-lab-eval/MMVP dataset which already has these corrections at source, and corrects the original MMVP/MMVP dataset when used. Fixes EvolvingLMMs-Lab#1018.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MMVP/MMVPorlmms-lab-eval/MMVPIn scope
lmms_eval/tasks/mmvp/utils.py: add idempotent ground-truth corrections for the four affected indices and wire throughmmvp_doc_to_target/mmvp_process_resultsOut of scope
Validation
python tests/test_mmvp_asset12.py| sample size:N=8| key metrics:correction assertions| result:passruff check lmms_eval/tasks/mmvp/utils.py| result:passRisk / Compatibility
MMVP/MMVPandlmms-lab-eval/MMVPType of Change
Fixes #1018