Cache stringifies where not needed#631
Merged
Luodian merged 2 commits intoApr 17, 2025
Merged
Conversation
…e object itself could be written. Raises error when value read out since str type not value type
Luodian
approved these changes
Apr 17, 2025
dadwadw233
pushed a commit
to dadwadw233/lmms-eval
that referenced
this pull request
Apr 28, 2025
* right now reading from cache returns stringified verions in case where object itself could be written. Raises error when value read out since str type not value type * rm try
stisiTT
pushed a commit
to bgoelTT/lmms-eval
that referenced
this pull request
Mar 6, 2026
* right now reading from cache returns stringified verions in case where object itself could be written. Raises error when value read out since str type not value type * rm try
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now reading from cache returns stringified versions in case where object itself could be written. Raises error when values read out of the cache since str type not Instance type.