Skip to content

[bugfix] fix bug in srt_api.py #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Luodian merged 2 commits into from
Sep 18, 2025
Merged

[bugfix] fix bug in srt_api.py #826

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea8a87b
fix bug
zzhbrr Sep 17, 2025
6911aaf
fix: Correct time_instruction variable name and add modality check fo…
Luodian Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lmms_eval/models/simple/srt_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,9 @@ async def generate(self, request):
imgs = None
break

time_instruciton = f"The video lasts for {video_time:.2f} seconds, and {len(frames)} frames are uniformly sampled from it. These frames are located at {frame_time}.Please answer the following questions related to this video."
if self.add_time_instruction:
contexts = f"{time_instruciton}\n{contexts}"
time_instruction = f"The video lasts for {video_time:.2f} seconds, and {len(frames)} frames are uniformly sampled from it. These frames are located at {frame_time}.Please answer the following questions related to this video."
if self.add_time_instruction and self.modality == "video" and imgs is not None:
contexts = f"{time_instruction}\n{contexts}"
else:
contexts = f"{contexts}"
# Handling video decode error
Expand Down Expand Up @@ -243,9 +243,9 @@ def generate_sync(self, request):
imgs = None
break

time_instruciton = f"The video lasts for {video_time:.2f} seconds, and {len(frames)} frames are uniformly sampled from it. These frames are located at {frame_time}.Please answer the following questions related to this video."
if self.add_time_instruction:
contexts = f"{time_instruciton}\n{contexts}"
time_instruction = f"The video lasts for {video_time:.2f} seconds, and {len(frames)} frames are uniformly sampled from it. These frames are located at {frame_time}.Please answer the following questions related to this video."
if self.add_time_instruction and self.modality == "video" and imgs is not None:
contexts = f"{time_instruction}\n{contexts}"
else:
contexts = f"{contexts}"
# Handling video decode error
Expand Down
Loading