Skip to content

Harden Visio comments loading to prevent XML DoS#1927

Merged
PrzemyslawKlys merged 2 commits into
masterfrom
fix-unbounded-xml-parsing-in-visio-comments
Jun 16, 2026
Merged

Harden Visio comments loading to prevent XML DoS#1927
PrzemyslawKlys merged 2 commits into
masterfrom
fix-unbounded-xml-parsing-in-visio-comments

Enforce Visio comment save limits

7f4b605
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 16, 2026 in 0s

73.33% (+1.03%) compared to 0d248cc

View this Pull Request on Codecov

73.33% (+1.03%) compared to 0d248cc

Details

Codecov Report

❌ Patch coverage is 70.00000% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.33%. Comparing base (0d248cc) to head (7f4b605).
⚠️ Report is 154 commits behind head on master.

Files with missing lines Patch % Lines
OfficeIMO.Visio/VisioDocument.LoadCore.Comments.cs 68.18% 11 Missing and 3 partials ⚠️
OfficeIMO.Visio/VisioDocument.SaveCore.Comments.cs 75.00% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1927      +/-   ##
==========================================
+ Coverage   72.30%   73.33%   +1.03%     
==========================================
  Files        1956     2521     +565     
  Lines      225358   283242   +57884     
  Branches    48654    60594   +11940     
==========================================
+ Hits       162943   207716   +44773     
- Misses      40161    47886    +7725     
- Partials    22254    27640    +5386     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.