Skip to content

Improve Markdown PDF visual rendering#1984

Merged
PrzemyslawKlys merged 24 commits into
masterfrom
codex/markdown-pdf-polish-20260620
Jun 21, 2026
Merged

Improve Markdown PDF visual rendering#1984
PrzemyslawKlys merged 24 commits into
masterfrom
codex/markdown-pdf-polish-20260620

Conversation

@PrzemyslawKlys

Copy link
Copy Markdown
Member

Summary

  • route Markdown PDF visual fences through MarkdownReader semantic AST extensions instead of PDF-side code-block interpretation
  • add native OfficeIMO chart rendering for semantic chart fences and styled fallback warnings for unsupported visual fences
  • improve Markdown image output with themed figure styles, captions, placeholders, image-only paragraphs, and chart/figure visual tests

Validation

  • dotnet test .\OfficeIMO.Tests\OfficeIMO.Tests.csproj -f net8.0 --filter "FullyQualifiedName~MarkdownSaveAsPdfVisualTests" -v:minimal
  • dotnet build .\OfficeIMO.Markdown.Pdf\OfficeIMO.Markdown.Pdf.csproj -v:minimal

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6d9f54dd9d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 580e6d5567

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
@codecov

codecov Bot commented Jun 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 74.57490% with 628 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.55%. Comparing base (8ac832c) to head (61d22d7).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...kdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs 79.94% 79 Missing and 71 partials ⚠️
OfficeIMO.Markdown/Options/MarkdownVisualTheme.cs 42.13% 96 Missing and 7 partials ⚠️
....Pdf/MarkdownPdfConverterExtensions.ChartSeries.cs 69.77% 60 Missing and 34 partials ⚠️
OfficeIMO.Markdown.Pdf/MarkdownPdfJson.cs 59.40% 62 Missing and 20 partials ⚠️
.../MarkdownPdfConverterExtensions.ChartValidation.cs 76.47% 15 Missing and 13 partials ⚠️
...MO.Markdown.Pdf/MarkdownPdfVisualTheme.Markdown.cs 78.44% 9 Missing and 16 partials ⚠️
OfficeIMO.Markdown/Options/MarkdownColor.cs 86.66% 12 Missing and 6 partials ⚠️
OfficeIMO.Markdown.Pdf/MarkdownPdfFigureStyle.cs 77.63% 9 Missing and 8 partials ⚠️
OfficeIMO.Markdown/Utilities/HtmlRenderer.cs 75.00% 3 Missing and 14 partials ⚠️
...n/Converters/MarkdownToWordConverter.Formatting.cs 82.47% 11 Missing and 6 partials ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1984      +/-   ##
==========================================
+ Coverage   73.52%   73.55%   +0.02%     
==========================================
  Files        2559     2571      +12     
  Lines      292953   295421    +2468     
  Branches    63248    63917     +669     
==========================================
+ Hits       215386   217285    +1899     
- Misses      48890    49210     +320     
- Partials    28677    28926     +249     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dd8884625f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Images.cs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2ecc6d980d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e4ece6e64a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Images.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Blocks.cs
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ee4549ac7d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Images.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bb73edd175

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.ChartSeries.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3b81886a26

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a9e4fbb7e0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.ChartSeries.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c3c962a4b3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.ChartSeries.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3893b66d84

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6b80a7593e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.ChartSeries.cs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c33d95c0d1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.ChartSeries.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: df220755fa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread OfficeIMO.Markdown/Utilities/HtmlRenderer.cs
Comment thread OfficeIMO.Markdown/Options/HtmlOptions.cs Outdated
Comment thread OfficeIMO.Word.Markdown/Converters/MarkdownToWordConverter.Formatting.cs Outdated
Comment thread OfficeIMO.Markdown/Utilities/HtmlRenderer.cs
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Panels.cs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7ff774c3c0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfVisualTheme.Markdown.cs
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Images.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.cs
Comment thread OfficeIMO.Markdown/Core/MarkdownDoc.cs
Comment thread OfficeIMO.Markdown/Utilities/HtmlRenderer.cs
Comment thread OfficeIMO.Markdown/Utilities/HtmlRenderer.cs Outdated
Comment thread OfficeIMO.Markdown/Utilities/HtmlRenderer.cs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e87ff985ea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfVisualTheme.Markdown.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfVisualTheme.Markdown.cs
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown/Utilities/HtmlRenderer.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7c2057c91b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs
Comment thread OfficeIMO.Word.Markdown/Converters/MarkdownToWordConverter.Formatting.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.ChartSeries.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.ChartSeries.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.ChartSeries.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.ChartSeries.cs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 604b1f34ac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfVisualTheme.Markdown.cs
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.ChartSeries.cs Outdated
Comment thread OfficeIMO.Word.Markdown/Converters/MarkdownToWordConverter.OmdInlines.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Word.Markdown/Converters/MarkdownToWordConverter.Formatting.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 720b195fa2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread OfficeIMO.Word.Markdown/Converters/MarkdownToWordConverter.Formatting.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

AppendInlines(builder, heading.Inlines, CreateInlineStyle(visualTheme).With(bold: true, fontSize: fontSize));

P2 Badge Apply shared heading color to H4+ PDFs

When MarkdownPdfSaveOptions.Theme customizes Palette.Heading, H1–H3 go through the PDF heading theme, but H4 and deeper headings are rendered as plain paragraphs with only bold/font size applied. Those lower-level headings inherit body/default text color instead of the shared heading color, so documents with H4+ headings are only partially themed; pass the heading color into this inline style or use themed heading styles for all levels.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread OfficeIMO.Word.Markdown/Converters/MarkdownToWordConverter.Formatting.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cc522ec570

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfVisualTheme.Markdown.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Panels.cs
Comment thread OfficeIMO.Word.Markdown/Converters/MarkdownToWordConverter.Formatting.cs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d52a321e6e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.ChartValidation.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs Outdated
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs
Comment thread OfficeIMO.Markdown.Pdf/MarkdownPdfConverterExtensions.Charts.cs
@PrzemyslawKlys PrzemyslawKlys merged commit 5a7564c into master Jun 21, 2026
21 checks passed
@PrzemyslawKlys PrzemyslawKlys deleted the codex/markdown-pdf-polish-20260620 branch June 21, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant