Conversation
majumdararn
left a comment
There was a problem hiding this comment.
Under Install ROBOT (necessary only once), one could add:
- Check whether java is installed using java –version
- Clone source code of 1.8.1 version (recommended in README) using git clone https://github.com/ontodev/robot.git robot-1.8.1
- Enter the cloned directory using cd robot-1.8.1
- Check if maven is installed using mvn –help
- If already installed, skip this. If not, sudo apt update; sudo apt install -y maven
- Build with maven using mvn install
- Check installation using java -jar bin/robot.jar --help
- Add following lines in .bashrc
## add robot to path
export PATH=$PATH:$CLONE_DIR/robot-1.8.1/bin
- Check if robot works using robot --help
majumdararn
left a comment
There was a problem hiding this comment.
I have two comments:
- Could we add precise instructions on how to add a new term or dependency?
- Could we add a link to this file in the README?
CONTRIBUTING.md
Outdated
|
|
||
| ### 3. Install ROBOT (necessary only once) | ||
| The PaNET.owl is generated from an Excel/CSV file using [ROBOT](https://central.sonatype.com/artifact/org.obolibrary.robot/robot?smo=true) software. Here are some instructions to generate the OWL file: | ||
| ??? |
There was a problem hiding this comment.
We perhaps should also mention the panet-build container image that provides a complete environment for building PaNET. This is likely an easy way for someone to get started.
CONTRIBUTING.md
Outdated
|
|
||
| ## How to Contribute <a name="howToContribute"></a> | ||
|
|
||
| ### Reporting Bugs / Suggesting Enhancements <a name="bugAndEnhancements"></a> |
There was a problem hiding this comment.
This reads like how to contribute when targeting code -- we don't really have any code.
Perhaps a better section would be how to request a new experimental technique, how to enhance an existing term, how to report a concern/problem, ...
da73db2 to
f3793aa
Compare
|
Thanks for the input!
Unfortunately, I don't know how to include the panet-build information here. @paulmillar could you please elaborate? |
f3793aa to
65b49bb
Compare
|
I'm afraid it's not yet fool proof enough... Is there maybe a step missing in the beginning where I have to fork the project into my own github space? I'm failing with the current instructions at the following step: sbusch@xps13:/tmp$ git clone https://github.com/ExPaNDS-eu/ExPaNDS-experimental-techniques-ontology
Cloning into 'ExPaNDS-experimental-techniques-ontology'...
remote: Enumerating objects: 1017, done.
remote: Counting objects: 100% (427/427), done.
remote: Compressing objects: 100% (223/223), done.
remote: Total 1017 (delta 300), reused 204 (delta 204), pack-reused 590 (from 1)
Receiving objects: 100% (1017/1017), 1.69 MiB | 6.59 MiB/s, done.
Resolving deltas: 100% (478/478), done.
sbusch@xps13:/tmp$ cd ExPaNDS-experimental-techniques-ontology
sbusch@xps13:/tmp/ExPaNDS-experimental-techniques-ontology$ ls
CHANGELOG.md docs examples LICENSE logo meetings README.md source
sbusch@xps13:/tmp/ExPaNDS-experimental-techniques-ontology$ git remote add upstream git@github.com:ExPaNDS-eu/ExPaNDS-experimental-techniques-ontology.git
sbusch@xps13:/tmp/ExPaNDS-experimental-techniques-ontology$ git fetch upstream
The authenticity of host 'github.com (140.82.121.4)' can't be established.
ED25519 key fingerprint is SHA256:blablabla.
This key is not known by any other names.
Are you sure you want to continue connecting (yes/no/[fingerprint])? yes
Warning: Permanently added 'github.com' (ED25519) to the list of known hosts.
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists. |
|
Let's try the following steps.
If this is not working, we need to get some more experienced people involved ;) |
|
One step further, thank you! git push origin HEAD
Username for 'https://github.com': .....git config -l
user.name=...
user.email=...
credential.helper=store
pull.rebase=true
core.repositoryformatversion=0
core.filemode=true
core.bare=false
core.logallrefupdates=true
remote.origin.url=https://github.com/ExPaNDS-eu/ExPaNDS-experimental-techniques-ontology
remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
branch.master.remote=origin
branch.master.merge=refs/heads/master
remote.upstream.url=git@github.com:ExPaNDS-eu/ExPaNDS-experimental-techniques-ontology.git
remote.upstream.fetch=+refs/heads/*:refs/remotes/upstream/* |
|
By the look for things, you're using the
I generally use 3., but 2. is also a valid choice. I would avoid 1. |
|
Right, let's go with option 3. Also, in @kara-mela's last comment, there is a "Configure git to use ssh: git remote set-url upstream git@github.com:username/repo.git", but the contributing.md does not contain such a line. Is it covered by the |
|
The distinctions between When working with a git service (e.g., GitHub or GitLab) it's pretty-much guaranteed that you don't have direct write access to the repository. To allow collaboration, these services (GitHub) allow people to make their own complete copy of the repo, called a fork (a process called "forking"). You make changes in your own copy and offer those changes, so people choose to accept your changes. Git makes working with multiple independent copies relatively easy. By convention, people name their own (personal) copy of the repo The choice of names doesn't actually matter; you could call them To contribute a change, you create a branch on your laptop/desktop, commit one (or more) changes, push that branch into The question of Just for reference, here's the $ git remote -v|grep ^[ou]
origin git@github.com:paulmillar/ExPaNDS-experimental-techniques-ontology.git (fetch)
origin git@github.com:paulmillar/ExPaNDS-experimental-techniques-ontology.git (push)
upstream git@github.com:ExPaNDS-eu/ExPaNDS-experimental-techniques-ontology.git (fetch)
upstream git@github.com:ExPaNDS-eu/ExPaNDS-experimental-techniques-ontology.git (push)
$ The I'm using $ git remote -v
melanie git@github.com:kara-mela/ExPaNDS-experimental-techniques-ontology.git (fetch)
melanie git@github.com:kara-mela/ExPaNDS-experimental-techniques-ontology.git (push)
origin git@github.com:paulmillar/ExPaNDS-experimental-techniques-ontology.git (fetch)
origin git@github.com:paulmillar/ExPaNDS-experimental-techniques-ontology.git (push)
terence git@github.com:terencetan-c/ExPaNDS-experimental-techniques-ontology.git (fetch)
terence git@github.com:terencetan-c/ExPaNDS-experimental-techniques-ontology.git (push)
upstream git@github.com:ExPaNDS-eu/ExPaNDS-experimental-techniques-ontology.git (fetch)
upstream git@github.com:ExPaNDS-eu/ExPaNDS-experimental-techniques-ontology.git (push)
$ The The |
Motivation Currently, PaNET does not fulfill the community standards for GitHub repositories, e.g. missing license, code of conduct, contributing, security policy, pull request template. Modification A CONTRIBUTING.md file has been added. Update: Installation details for ROBOT (incl. panet-build), instructions for new terms and technique updates, link from README.md. Result Improving the overall quality of the repository. Contributes to ExPaNDS-eu#324
65b49bb to
ab8882b
Compare
|
During the hackathon on 2026-01-16, we decided to restructure the document. New version is available now. |
|
The problem described above persists |
|
I guess, we need to sit together and try to solve this. The results of this session will be used to improve the document. |
Motivation
Currently, PaNET does not fulfill the community standards for GitHub repositories, e.g. missing license, code of conduct, contributing, security policy, pull request template.
Modification
A CONTRIBUTING.md file has been added.
Result
Improving the overall quality of the repository.
Contributes to #324