Open
Conversation
Motivation To extend the possibilities to apply PaNET, mappings to relevant established sources are highly useful. In order to provide a structured approach to create mappings, providing some guidelines would be useful. Modification An md file with guidelines has been added, as well as a template in csv format. Result Future mappings will be easier to create and will have a well-defined structure. Related Issues closes ExPaNDS-eu#288
Collaborator
|
Can you check if the commata in the header of the .csv are correct. I have the idea they should not be there. |
Collaborator
Author
|
@hgoerzig: Thanks for checking carefully. The commas in the csv are correct (otherwise it wouldn't be a valid csv). You are right that the sssom commands can't handle them, therefore I added the first step in the makefile to create a copy and strip off the commas in the header. The second step is then sssom convert. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
To extend the possibilities to apply PaNET, mappings to relevant established sources are highly useful. In order to provide a structured approach to create mappings, providing some guidelines would be useful.
Modification
An md file with guidelines has been added, as well as a template in csv format.
Result
Future mappings will be easier to create and will have a well-defined structure. Related Issues
Related Issues
closes #288