Correcting order of ultra and very small angle scattering#346
Open
kara-mela wants to merge 1 commit intoExPaNDS-eu:masterfrom
Open
Correcting order of ultra and very small angle scattering#346kara-mela wants to merge 1 commit intoExPaNDS-eu:masterfrom
kara-mela wants to merge 1 commit intoExPaNDS-eu:masterfrom
Conversation
Motivation Issue ExPaNDS-eu#318 stated that 'very small angle neutron scattering technique' (VSANS) is not a subclass of the 'ultra small angle neutron scattering technique' (USANS). After a discussion during the DAPHNE TA1 meeting on 14 Jan 2026, it was clarified that the order is SANS - VSANS - USANS. Modification The equivalence of VSANS to SAND and USAS was deleted. Instead, VSANS has now the new parent SANS. The parent VSANS of USANS was deleted. Instead, USANS is now equivalent to SANS and USAS. Result The intended order of the angles is established.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Issue #318 stated that 'very small angle neutron scattering technique' (VSANS) is not a subclass of the 'ultra small angle neutron scattering technique' (USANS). After a discussion during the DAPHNE TA1 meeting on 14 Jan 2026, it was clarified that the order is SANS - VSANS - USANS.
Modification
The equivalence of VSANS to SAND and USAS was deleted. Instead, VSANS has now the new parent SANS.
The parent VSANS of USANS was deleted. Instead, USANS is now equivalent to SANS and USAS.
Before:
After (only neutron branch:
Result
The intended order of the angles is established.
Related Issues
Closes #318