Refactor: BGP-LS node attributes to packed-bytes-first pattern

Convert remaining BGP-LS node attribute classes to properly use
BaseLS.__init__(packed: bytes) and @Property content accessors:

- IsisArea: content property unpacks int from hex
- LocalTeRid: content property unpacks list[str], custom merge
- NodeOpaque: content property returns raw bytes
- SrAlgorithm: content property unpacks list[int]

Progress: ~90% complete (105/118 convertible classes)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: thomas-mangin

plan/packed-bytes/progress.md

@@ -198,16 +198,16 @@ cached instances for identical parameter combinations.
 | `attribute/bgpls/link/temetric.py` | TeMetric | ✅ | `make_temetric(int)` |
 | `attribute/bgpls/link/unrsvpbw.py` | UnRsvpBw | ✅ | `make_unrsvpbw(list[float])` |
 
-### BGP-LS Node Attributes 🔄 PARTIAL
+### BGP-LS Node Attributes ✅ COMPLETE
 
 | File | Class | Status | Notes |
 |------|-------|--------|-------|
-| `attribute/bgpls/node/isisarea.py` | IsisArea | ⏳ | |
-| `attribute/bgpls/node/lterid.py` | LocalTeRid | ⏳ | |
+| `attribute/bgpls/node/isisarea.py` | IsisArea | ✅ | `content` property unpacks int |
+| `attribute/bgpls/node/lterid.py` | LocalTeRid | ✅ | `content` property unpacks list[str] |
 | `attribute/bgpls/node/nodeflags.py` | NodeFlags | ✅ | (FlagLS, use `unpack_bgpls`) |
 | `attribute/bgpls/node/nodename.py` | NodeName | ✅ | `make_nodename(str)` |
-| `attribute/bgpls/node/opaque.py` | NodeOpaque | ⏳ | |
-| `attribute/bgpls/node/sralgo.py` | SrAlgorithm | ⏳ | |
+| `attribute/bgpls/node/opaque.py` | NodeOpaque | ✅ | `content` property returns bytes |
+| `attribute/bgpls/node/sralgo.py` | SrAlgorithm | ✅ | `content` property unpacks list[int] |
 | `attribute/bgpls/node/srcap.py` | SrCapabilities | ✅ | Properties unpack from `_packed` |
 
 ### BGP-LS Prefix Attributes 🔄 PARTIAL
@@ -321,14 +321,14 @@ cached instances for identical parameter combinations.
 | Wave 1 | 4 | 0 | 0 | 0 | 4 |
 | Wave 2 | 10 | 0 | 0 | 1 | 11 |
 | Wave 3 | ~20 | 0 | 0 | 0 | ~20 |
-| Wave 4 | ~31 | 0 | ~16 | 3 | ~50 |
+| Wave 4 | ~35 | 0 | ~12 | 3 | ~50 |
 | Wave 5 | 5 | 0 | 0 | 0 | 5 |
 | Wave 6 | 5 | 1 | 0 | 3 | 9 |
 | Wave 7 | ~20 | 0 | 0 | 0 | ~20 |
 | Wave 8 | 6 | 0 | 0 | 0 | 6 |
-| **TOTAL** | **~101** | **1** | **~16** | **7** | **~125** |
+| **TOTAL** | **~105** | **1** | **~12** | **7** | **~125** |
 
-**Completion: ~86%** (101 done + 1 partial out of ~118 convertible classes)
+**Completion: ~90%** (105 done + 1 partial out of ~118 convertible classes)
 
 ---
 
@@ -341,7 +341,8 @@ cached instances for identical parameter combinations.
 - Updated GenericSrv6* classes: reordered params to `__init__(packed, code)`
 - Marked Srv6L2Service/L3Service/SidInformation as N/A (container pattern like PrefixSid)
 - Updated call sites in `configuration/static/mpls.py`
-- All 9 test suites pass (89 SR-specific tests)
+- Converted BGP-LS Node attributes (IsisArea, LocalTeRid, NodeOpaque, SrAlgorithm) to use `content` property
+- All 9 test suites pass
 
 ### 2025-12-04 (Session 2)
 - Converted MPRNLRI/MPURNLRI to hybrid packed-bytes pattern
@@ -361,7 +362,6 @@ Converted BGP-LS base classes and key subclasses to packed-bytes-first pattern:
 
 ## Next Priority
 
-**Remaining Wave 4 classes** (~16 pending):
-1. BGP-LS node attributes (IsisArea, LocalTeRid, NodeOpaque, SrAlgorithm)
-2. BGP-LS prefix attributes (IgpExTags, IgpFlags, IgpTags, PrefixOpaque, OspfForwardingAddress, SrIgpPrefixAttr, SrSourceRouterID)
-3. BGP-LS link SRv6 attributes (Srv6Capabilities, Srv6EndpointBehavior, Srv6Locator, Srv6SidStructure)
+**Remaining Wave 4 classes** (~12 pending):
+1. BGP-LS prefix attributes (IgpExTags, IgpFlags, IgpTags, PrefixOpaque, OspfForwardingAddress, SrIgpPrefixAttr, SrSourceRouterID)
+2. BGP-LS link SRv6 attributes (Srv6Capabilities, Srv6EndpointBehavior, Srv6Locator, Srv6SidStructure)

src/exabgp/bgp/message/update/attribute/bgpls/node/isisarea.py

@@ -26,14 +26,16 @@ class IsisArea(BaseLS):
     REPR = 'ISIS area id'
     JSON = 'area-id'
 
-    def __init__(self, areaid: int) -> None:
-        BaseLS.__init__(self, areaid)
-
     @classmethod
     def unpack_bgpls(cls, data: bytes) -> IsisArea:
         if not data:
             raise Notify(3, 5, 'ISIS Area: empty data')
-        return cls(int(data.hex(), 16))
+        return cls(data)
+
+    @property
+    def content(self) -> int:
+        """ISIS area ID as integer."""
+        return int(self._packed.hex(), 16)
 
     def json(self, compact: bool = False) -> str:
         return f'"{self.JSON}": "{self.content}"'

src/exabgp/bgp/message/update/attribute/bgpls/node/lterid.py

@@ -28,8 +28,10 @@ class LocalTeRid(BaseLS):
     REPR = 'Local TE Router IDs'
     JSON = 'local-te-router-ids'
 
-    def __init__(self, terids: list[str]) -> None:
-        BaseLS.__init__(self, terids)
+    def __init__(self, packed: bytes) -> None:
+        self._packed = packed
+        # For merge support, content is a list of packed bytes
+        self._content_list: list[bytes] = [packed]
 
     @classmethod
     def unpack_bgpls(cls, data: bytes) -> LocalTeRid:
@@ -38,7 +40,16 @@ def unpack_bgpls(cls, data: bytes) -> LocalTeRid:
         if length not in (4, 16):
             raise Notify(3, 5, 'Invalid remote-te size')
 
-        return cls([str(IP.unpack_ip(data))])
+        return cls(data)
+
+    @property
+    def content(self) -> list[str]:
+        """List of TE Router IDs as strings."""
+        return [str(IP.unpack_ip(data)) for data in self._content_list]
+
+    def merge(self, other: 'LocalTeRid') -> None:
+        """Merge another LocalTeRid's packed bytes into this one."""
+        self._content_list.extend(other._content_list)
 
     def json(self, compact: bool = False) -> str:
         joined = '", "'.join(self.content)

src/exabgp/bgp/message/update/attribute/bgpls/node/opaque.py

@@ -7,7 +7,6 @@
 from __future__ import annotations
 
 import json
-from struct import unpack
 
 from exabgp.bgp.message.update.attribute.bgpls.linkstate import BaseLS
 from exabgp.bgp.message.update.attribute.bgpls.linkstate import LinkState
@@ -32,12 +31,14 @@ class NodeOpaque(BaseLS):
     REPR = 'Node Opaque attribute'
     JSON = 'opaque'
 
-    def __init__(self, opaque: bytes) -> None:
-        BaseLS.__init__(self, opaque)
-
     @classmethod
     def unpack_bgpls(cls, data: bytes) -> NodeOpaque:
-        return cls(unpack('!%ds' % len(data), data)[0])
+        return cls(data)
+
+    @property
+    def content(self) -> bytes:
+        """Opaque data as bytes."""
+        return self._packed
 
     def json(self, compact: bool = False) -> str:
-        return f'"{self.JSON}": {json.dumps(self.content)}'
+        return f'"{self.JSON}": {json.dumps(self._packed.hex())}'

src/exabgp/bgp/message/update/attribute/bgpls/node/sralgo.py

@@ -30,19 +30,17 @@ class SrAlgorithm(BaseLS):
     REPR = 'SrAlgorithms'
     JSON = 'sr-algorithms'
 
-    def __init__(self, sr_algos: list[int]) -> None:
-        BaseLS.__init__(self, sr_algos)
-
     @classmethod
     def unpack_bgpls(cls, data: bytes) -> SrAlgorithm:
         # Looks like IOS XR advertises len 0 on this sub TLV
         # when using default SPF.
-        return cls(
-            [_ for _ in data]
-            or [
-                0,
-            ],
-        )
+        return cls(data)
+
+    @property
+    def content(self) -> list[int]:
+        """List of SR algorithm values."""
+        # Empty data means default SPF algorithm (0)
+        return list(self._packed) or [0]
 
     def json(self, compact: bool = False) -> str:
         return f'"{self.JSON}": {json.dumps(self.content)}'