QA utility script setup and testing#1280
Merged
thomas-mangin merged 1 commit intomainfrom Nov 7, 2025
Merged
Conversation
The functional test script was failing to report test timeouts correctly, causing tests that timed out to exit with success (0) instead of failure (1). This issue affected all three test types (encoding, decoding, and parsing): - When tests exceeded the timeout threshold, they were marked as failed but the success variable was never set to False - This caused CI/CD to incorrectly report test runs as successful even when tests actually failed due to timeout The fix adds `success = False` in the timeout cleanup loop for: - EncodingTests.run_selected() (line 526) - DecodingTests.run_selected() (line 663) - ParsingTests.run_selected() (line 738) This ensures that any test timeout is correctly reported as a failure, allowing CI/CD to properly detect and report test failures. Fixes: Test V (api-teardown) and any other tests that timeout
thomas-mangin
deleted the
claude/qa-bin-utility-011CUrmahLpVRhtBhcf1DKr7
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functional test script was failing to report test timeouts correctly, causing tests that timed out to exit with success (0) instead of failure (1).
This issue affected all three test types (encoding, decoding, and parsing):
The fix adds
success = Falsein the timeout cleanup loop for:This ensures that any test timeout is correctly reported as a failure, allowing CI/CD to properly detect and report test failures.
Fixes: Test V (api-teardown) and any other tests that timeout