Conversation
a479133 to
1d39f64
Compare
|
@mergify backport 0.28.x |
✅ Backports have been createdDetails
Cherry-pick of 1d39f64 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
There was a problem hiding this comment.
Pull request overview
This PR transitions from nightly releases to tag-based releases only, adding sigstore signing for build artifacts. The change addresses issues with GitHub's immutable releases feature by eliminating scheduled nightly releases while maintaining release functionality for version tags.
Changes:
- Added sigstore signing to all build jobs (Linux, macOS, Windows) with appropriate permissions
- Removed nightly release logic and cleanup scripts
- Simplified release job to only trigger on push events (version tags)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3479 +/- ##
=======================================
Coverage 64.91% 64.91%
=======================================
Files 116 116
Lines 21479 21479
Branches 10655 10655
=======================================
Hits 13943 13943
Misses 5311 5311
Partials 2225 2225 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I tested this on my fork to make sure it works: https://github.com/kevinbackhouse/exiv2/actions/runs/22025342561 |
|
Any problems foreseen/objections deleting the actual |
Good point, I'll delete the old nightly tags and releases. Because I accidentally created an immutable "nightly" release, we can never create a release with that name again, but I don't think we're prevented from deleting the old one. |
|
Also, shall we try adding the |
I recently switched on immutable releases which broke our nightly release. I think the best solution is to stop doing the nightly release. The build artifacts can be found by checking the recent workflow runs, so it's unnecessary to also upload them as a release.
I also added sigstore to the workflow to sign the builds.