add enforce to prevent integer overflow#3512
Merged
kevinbackhouse merged 2 commits intoExiv2:mainfrom Feb 27, 2026
Merged
Conversation
Collaborator
Author
|
@mergify backport 0.28.x |
Contributor
✅ Backports have been createdDetails
Cherry-pick of fe0d015 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
There was a problem hiding this comment.
Pull request overview
This PR adds integer overflow protection when processing native preview data in EPS files. The change prevents potential crashes or undefined behavior when the data size is less than the required header offset.
Changes:
- Added validation check to prevent integer overflow in preview data processing
- Added regression test for issue 3511 with malformed EPS file
- Excluded the test file from general regression testing
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/preview.cpp | Added enforcement check to validate data size before offset calculation |
| tests/bugfixes/github/test_issue_3511.py | Added test case to verify the fix handles malformed EPS files correctly |
| tests/regression_tests/test_regression_allfiles.py | Excluded the test file from general regression tests |
| test/data/issue_3511_poc.eps | Added proof-of-concept EPS file that triggers the overflow condition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kmilos
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #3511