Skip to content

[Template] Remove some unsecure DOM interpretation #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeurimpulsif merged 1 commit into from
Dec 6, 2025
Merged

[Template] Remove some unsecure DOM interpretation #682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions exodus/reports/templates/reports_list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ <h4>
<hr>
{% if not handle %}
<select class="custom-select"
onchange="this.options[this.selectedIndex].value && (window.location = '/{{ LANGUAGE_CODE }}/reports/list' + this.options[this.selectedIndex].value);">
<option value=" ">{% trans "Latest reports" %}</option>
onchange="const new_value = this.options[this.selectedIndex].value; if (new_value == '?filter=most_trackers') {window.location = '?filter=most_trackers';} else if (new_value == '?filter=no_trackers') {window.location = '?filter=no_trackers';} else {window.location = '?';}">
<option value="?">{% trans "Latest reports" %}</option>
<option value="?filter=most_trackers" {% if filter == 'most_trackers' %}selected{% endif %}>
{% trans "Sorted by number of trackers" %}</option>
<option value="?filter=no_trackers" {% if filter == 'no_trackers' %}selected{% endif %}>
Expand Down
4 changes: 2 additions & 2 deletions exodus/trackers/templates/trackers_list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ <h4>
<div class="col-xl-4 col-lg-5 col-md-8 col-12 mb-2">
{% trans "Sorted by" %}&nbsp;
<select class="custom-select"
onchange="this.options[this.selectedIndex].value && (window.location = '/{{ LANGUAGE_CODE }}/trackers/' + this.options[this.selectedIndex].value);">
<option value=" ">
onchange="const new_value = this.options[this.selectedIndex].value; if (new_value == '?filter=apps') {window.location = '?filter=apps';} else {window.location = '?';}">
<option value="?">
{% trans "Alphabetical order" %}
</option>
<option value="?filter=apps" {% if filter == 'apps' %}selected{% endif %}>
Expand Down
Loading