feat(reports): explain tracker presence vs activity on report pages - #701
Open
Manny7717 wants to merge 1 commit into
Open
feat(reports): explain tracker presence vs activity on report pages#701Manny7717 wants to merge 1 commit into
Manny7717 wants to merge 1 commit into
Conversation
Adds an info icon next to the trackers count on report details pages. Its tooltip explains that trackers are detected by static analysis of the application code and that their presence does not mean they are active, with a link to the FAQ section on the topic. Closes Exodus-Privacy#638
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a short explanation on report detail pages that a tracker detected by static analysis is present in the application code, but that its presence does not prove it is active.
This has been a recurring source of confusion for users looking at report pages only (see the discussion in #638 — several people contacted the project by email/social media assuming any listed tracker means data collection is happening).
How
static/img/info.svginfo icon next to the trackers count heading.data-toggle="tooltip"pattern already used elsewhere on this page) with the explanation, and links to the FAQ section that goes into detail: https://exodus-privacy.eu.org/en/page/faq/#negativesThe existing note in the report footer stays; this makes the explanation visible right where the tracker count is read.
Tests
test_report_details_page_explains_tracker_presence_is_not_proof_of_activityrendering a report details page and asserting the FAQ link and icon are present.manage.py test→ 69/69 OK.flake8clean on changed files.