fix(analysis): reject submissions without an application handle - #705
Open
Manny7717 wants to merge 1 commit into
Open
fix(analysis): reject submissions without an application handle#705Manny7717 wants to merge 1 commit into
Manny7717 wants to merge 1 commit into
Conversation
The handle field is blank=True (required for APK uploads), which makes Django skip its model validators for empty values. As a result an analysis could be submitted without a handle, and only a bypassable HTML check kept it from happening (see Exodus-Privacy#296/Exodus-Privacy#297). Add explicit form-level validation: the analysis form now requires a handle, while the APK upload form is unaffected. Closes Exodus-Privacy#297
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Submitting an analysis with an empty handle was accepted by the backend: the
handlefield isblank=True(needed for APK uploads), and Django'srun_validatorsskips model validators for empty values of blank fields. The only guard was a client-side HTML check that can be bypassed (see #296 / #297).Change
AnalysisRequestForm.clean()now rejects an empty handle with a field error. The APK upload path (UploadRequestForm) is unchanged.Tests
AnalysisRequestFormTests: empty handle → form invalid with error onhandle; valid handle (store lookup mocked) → valid.AnalysisRequestForm({'handle': '', 'source': 'google'}).is_valid()returnedTruebefore the fix.