Conversation
|
@ChALkeR there are some conflicts here |
Contributor
Author
|
@mvayngrib Let's call this not a v2 but a separate lib perhaps. |
gutenye
reviewed
Oct 7, 2025
| return res.json() | ||
| } | ||
|
|
||
| const err = new Error(res.statusText) |
There was a problem hiding this comment.
Suggested change
| const err = new Error(res.statusText) | |
| const err = new Error(`${res.status} ${res.statusText || ''}`.trim()) |
Fix the statusText is undefined case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 1.7.0,
@exodus/fetchalready just prefers to use globalfetchandWebSocketWhich covers all platforms we need
Instead of doing gradual changes and optimizing out code, let's just remove everything we don't use/need and call this a v2
fetchivalis replaced withexperimental/fetchivaland is renamed tofetcherto avoid confusion, as the API differsCompared to
fetchival, new API is hardened to prevent unescaped injection of url components (previously was available asexperimental/fetchival)Compared to
experimental/fetchival, the non-standardtimeoutoption default value is removed (reverted tofetchivalbehavior)Also switched to ESM and
@exodus/testAlso 0-dep now
This is a somewhat work in progress, I might improve this further