fix: wretch default export compatibility in CommonJS#32
Merged
Conversation
feri42
approved these changes
Mar 10, 2025
feri42
left a comment
feri42
left a comment
There was a problem hiding this comment.
utACK -- Was this also tested on platforms?
Contributor
Author
Yes, tested on desktop build |
|
🎉 This PR is included in version 1.7.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
@thanhdanh we don't have PRs for Mobile and BE? |
Contributor
|
I don't think this works. |
Contributor
|
Fix in #33 |
Contributor
|
Side note: I'm unsure why we even have/need |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue where
wretchwas being called as a function but threw an error (wretch is not a function).The issue occurred because
wretch.browser.jsexports wretch as an ESModule default export, and when imported viarequire, the default export is wrapped inside a.defaultproperty. This fix explicitly accesses the.defaultproperty when importingwretch.browser.jsinwretch.js, ensuring compatibility with CommonJS.Tested on integration tests of
tron-api,solana-api