Open
Conversation
mvayngrib
approved these changes
Sep 24, 2024
Contributor
|
to clarify, removing this fixes the git diff exit code, right? |
Collaborator
Author
|
Yes, correct. I also reported the bug in the mailing list but haven't heard anything so far |
Contributor
|
could u link that mailing list thread? |
Collaborator
Author
|
Looks like they don't want my bug report 🤔 
|
Contributor
|
i see you have a reputation outside Exodus too 😉 |
Collaborator
Author
hahaha, unfortunately yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a bug in git
2.46.xpreventinggit diff --exit-codeorgit diff --quietexiting with a non-zero exit code when there is a diff in a file declared as binary in.gitattributes. This will effectively disable our CI check to make sure that the action has been built and committed.