Add contacts import nitro module

[perunt]

Explanation of Change

https://github.com/Expensify/Mobile-Expensify/pull/13516 - use this PR for Mobile-Expensify

During the revert of the NitroModules PR, we identified two main issues affecting our iOS builds. First, there was a mismatch between the minimum iOS deployment target (set to 13.4) and our app's requirement (iOS 15). Second, we discovered build failures specific to iOS simulators due to a known Swift compiler issue.
While investigating, we found that our CI environment was running an older version of Xcode (15.2), which contributed to the build failures. We've addressed this by updating our CI configuration to use newer macOS runners and updating the Ruby GitHub Action version.
To move forward cleanly, we'll be splitting this into two separate PRs:

• CI infrastructure update for newer Xcode support
• Re-introduction of ContactsModule with correct iOS configuration

After implementing these changes in isolation, our test builds are now passing successfully.

revert #54421

Fixed Issues

$ #47938
PROPOSAL:

Tests

See QA steps.

• Verify that no errors appear in the JS console

Offline tests

QA Steps

Setup Prerequisites

1. Clean installation of the app on Android and iOS devices
2. No prior contact permissions granted
3. Device with test contacts available

Test Steps

1. Basic Flow - First Time Access

1. Launch the app
2. Press the '+' button
3. Select 'create expense' from the menu
4. Navigate to the create expenses page
5. Take a photo of expenses
6. Verify: Navigation to recipient list occurs
7. Verify: Soft permission modal appears (first-time only)

2. Soft Permission Modal - "Not Now" Path

1. On the soft permission modal, press "Not Now"
2. Verify: Modal closes without showing contact permission
3. Verify: Recipient list is displayed without phone contacts
4. Exit to the app home screen
5. Repeat steps to reach recipient list
6. Verify: Soft permission modal does NOT appear again within this app session

3. Soft Permission Modal - "Continue" Path

1. On the soft permission modal, press "Continue"
2. Verify: Soft permission modal closes
3. Verify: Native contact permission modal appears

4. Contact Permission - Deny Access

1. On the native permission modal, press "Deny" or "Don't Allow"
2. Verify: Modal closes
3. Verify: Recipient list appears without phone contacts
4. Verify: Button for importing contacts appears at the bottom of the list
5. Press the import contacts button
6. Verify: Navigation to permission settings occurs

5. Contact Permission - Allow Access

1. On the native permission modal, press "Allow" or "OK"
2. Verify: Modal closes
3. Verify: Contacts appear in the participant/recipient list

6. Search Functionality

1. Deny contact access
2. In the recipient list, perform a search that yields no results
3. Verify: Clickable text for importing contacts appears
4. Press the import contacts text
5. Verify: Navigation to permission settings occurs

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[perunt]

I didn't test the Hybrid App as I don't have access yet

[melvin-bot]

@shawnborton @DylanDylann One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[staszekscp]

Hey! I've created a PR with adjustments so everything works fine with HybridApp

[mateuuszzzzz]

Hi! @perunt what's your Xcode version locally? I'm testing PR on HybridApp and I cannot build for simulators (it builds fine on physical device tho). My version is 16.2 (16C5032a)

I'm also curious about swiftc version. Here is mine: swift-driver version: 1.115.1 Apple Swift version 6.0.3 (swiftlang-6.0.3.1.10 clang-1600.0.30.1)

The key information here is that some people might encounter issues when building on a simulator, while others might not, depending on their Swift compiler version. This can block HybridApp development for people without physical iPhone

[mateuuszzzzz]

Nevertheless I think this is not a serious issue and we can proceed further with this PR and its HybridApp part 😅

People experiencing issues with the Swift compiler can try downgrading their Xcode version or using a physical device if available. cc: @Julesssss

[mateuuszzzzz]

I think only remaining thing is to bump Xcode on CI infrastructure. I have this PR that was created before Christmas: #54424
I will sync it with main later today

[blimpich]

Tentatively approving, seems like we need to confirm first that this doesn't break hybrid app for simulator's as per above comments.

[blimpich]

Also I think we need to merge main due to xcode being bumped, which is why the validate github actions check is failing.

[perunt]

I'm still dealing with Android errors after bumping RN. I'll ping you once it's done

[perunt]

@roryabraham Here's what I've done:

• updated useAppState
• cleaned project.pbxproj
• refactored useContactPermissions
• replaced union type ContactFields that we added recently since they are not supported by Nitrogen yet

Spellcheck is off due to the margelo lib in the code. I don't want to exclude that file since it can be useful there

EDIT: Currently running the build for all platforms to double-check everything works

[blimpich]

Looks like we still have lint failures. Can you fix that @perunt?

[perunt]

@blimpich, it wants me to remove TABLE_REPORT_VIEW from all screens since I touched beta files by adding NATIVE_CONTACT_IMPORT. Can we ignore it since there's a separate PR with removing TABLE_REPORT_VIEW? #63254

[blimpich]

@blimpich, it wants me to remove TABLE_REPORT_VIEW from all screens since I touched beta files by adding NATIVE_CONTACT_IMPORT. Can we ignore it since there's a separate PR with removing TABLE_REPORT_VIEW? #63254

Yup sounds good thanks for the explanation!

[roryabraham]

We can fix cspell by adding margelo here

[roryabraham]

I agree with ignoring the changed-files eslint check, and I'm willing to ignore the cspell and fix it separately just because I don't want to further delay this long-standing PR.

[melvin-bot]

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[roryabraham]

skipped tests explained in my last comment

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[pac-guerreiro]

@roryabraham @perunt

This change broke some components that are passing listFooterContent to SelectionList!

Here is an example:

[DylanDylann]

@perunt It seems this is a serious bug, could you please raise a quick PR to update it again?

[pac-guerreiro]

@DylanDylann a fix was already merged here: #63887 😄

[github-actions]

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.1.64-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.64-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅