Enable ESLint rule / DEV alert() to match with useOnyx `canBeMissing` option #59191

fabioh8010 · 2025-03-26T21:10:41Z

Explanation of Change

Fixed Issues

$ #58499
PROPOSAL:

Tests

Change one of the useOnyx()s of FreeTrial.tsx component to set the canBeMissing flag.

diff --git a/src/pages/settings/Subscription/FreeTrial.tsx b/src/pages/settings/Subscription/FreeTrial.tsx
index 1d82614d66f..b3872873c3f 100644
--- a/src/pages/settings/Subscription/FreeTrial.tsx
+++ b/src/pages/settings/Subscription/FreeTrial.tsx
@@ -23,7 +23,7 @@ type FreeTrialProps = {
function FreeTrial({badgeStyles, pressable = false, addSpacing = false, success = true, inARow = false}: FreeTrialProps) {
    const styles = useThemeStyles();
    const [policies] = useOnyx(ONYXKEYS.COLLECTION.POLICY);
-    const [firstDayFreeTrial] = useOnyx(ONYXKEYS.NVP_FIRST_DAY_FREE_TRIAL);
+    const [firstDayFreeTrial] = useOnyx(ONYXKEYS.NVP_FIRST_DAY_FREE_TRIAL, {canBeMissing: false});
    const [lastDayFreeTrial] = useOnyx(ONYXKEYS.NVP_LAST_DAY_FREE_TRIAL);
    const [privateSubscription] = useOnyx(ONYXKEYS.NVP_PRIVATE_SUBSCRIPTION);

Create a new account and sign in.
Switch between Settings and Inbox in order to trigger the alert.
Assert an alert is displayed both visually and in the console.

Verify that no errors appear in the JS console

Offline tests

Same as above.

QA Steps

Not possible for QA to test this.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-24.at.17.06.34-compressed.mov

Android: mWeb Chrome

I'm having problems with my emulators when opening the Chrome app (they crash instantly), so I couldn't record videos for this platform.

iOS: Native

Screen.Recording.2025-03-24.at.17.38.16-compressed.mov

iOS: mWeb Safari

Screen.Recording.2025-03-24.at.17.39.48-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-24.at.17.42.18-compressed.mov

Screen.Recording.2025-03-24.at.17.43.10-compressed.mov

MacOS: Desktop

Screen.Recording.2025-03-24.at.17.46.40-compressed.mov

github-actions · 2025-03-26T21:10:51Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

TMisiukiewicz · 2025-03-27T10:54:56Z

Can we bump Onyx straight to 2.0.96 so my PR gets there as well?

github-actions · 2025-03-28T19:11:57Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

melvin-bot · 2025-03-28T19:20:29Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fabioh8010 · 2025-03-28T19:22:25Z

This PR is waiting for Expensify/react-native-onyx#624 to be merged and available in a new release so we can use it here.

Additionally, in order to keep the changes scoped I won't fix the ESLint errors (that are caused by the rule enabled in this very PR)

github-actions · 2025-04-02T06:37:40Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

fabioh8010 · 2025-04-02T06:42:34Z

This PR is waiting for Expensify/react-native-onyx#624 to be merged and available in a new release so we can use it here.

Additionally, in order to keep the changes scoped I won't fix the ESLint errors (that are caused by the rule enabled in this very PR)

PR is ready to review @parasharrajat @iwiznia

parasharrajat · 2025-04-02T10:26:00Z

I believe the first time every key will always be empty. It needs to be loaded from the backend then this logic will alert it.

So we are saying we will migrate all the useOnyx calls to have this key, which should not alert. Is that correct?

parasharrajat · 2025-04-03T18:07:47Z

Screenshots

🔲 iOS / native

04.04.2025_01.19.42_REC.mp4

🔲 iOS / Safari

🔲 MacOS / Desktop

04.04.2025_00.31.09_REC.mp4

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat · 2025-04-03T18:44:06Z

It would have been great if this showed the key name as well.

github-actions · 2025-04-07T09:57:23Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

fabioh8010 · 2025-04-07T10:01:44Z

I believe the first time every key will always be empty. It needs to be loaded from the backend then this logic will alert it.

So we are saying we will migrate all the useOnyx calls to have this key, which should not alert. Is that correct?

@parasharrajat The plan is to migrate all useOnyx calls to specify this flag, to be true or false. If we put true` the hook won't alert anything, otherwise it will alert if data from that Onyx key is undefined.

But after thinking about it for a while, I just feel that we'll end up marking almost useOnyx with canBeMissing set to true. I think it's just hard to predict if a Onyx key will always have some data or not.

@iwiznia WDYT about this?

fabioh8010 · 2025-04-09T10:05:49Z

@parasharrajat @iwiznia

Looks like there was a newer Onyx Bump PR which was merged today, so this PR is focusing now only in enabling the ESLint rule and the DEV alert().

iwiznia · 2025-04-09T15:17:29Z

But after thinking about it for a while, I just feel that we'll end up marking almost useOnyx with canBeMissing set to true. I think it's just hard to predict if a Onyx key will always have some data or not.

It's fine to set most of them to true as long as the code is ready to handle that, the problem right now is that a lot of places just assume some data will be loaded when it is not.

iwiznia

Looks good but you need to add the flag to the calls in Expensify.ts file, no?

parasharrajat · 2025-04-09T15:32:16Z

We should update the Expensify.tsx file.

src/Expensify.tsx

iwiznia · 2025-04-14T14:10:06Z

src/Expensify.tsx

-    const [screenShareRequest] = useOnyx(ONYXKEYS.SCREEN_SHARE_REQUEST);
-    const [focusModeNotification] = useOnyx(ONYXKEYS.FOCUS_MODE_NOTIFICATION, {initWithStoredValues: false});
-    const [lastVisitedPath] = useOnyx(ONYXKEYS.LAST_VISITED_PATH);
+    const [account] = useOnyx(ONYXKEYS.ACCOUNT, {canBeMissing: true});


This key can be missing? Is it when you are logged out?

account will alert if i'm logged out and I click one of these

iwiznia · 2025-04-14T14:10:25Z

src/Expensify.tsx

+    const [account] = useOnyx(ONYXKEYS.ACCOUNT, {canBeMissing: true});
+    const [session] = useOnyx(ONYXKEYS.SESSION, {canBeMissing: false});
+    const [lastRoute] = useOnyx(ONYXKEYS.LAST_ROUTE, {canBeMissing: true});
+    const [userMetadata] = useOnyx(ONYXKEYS.USER_METADATA, {canBeMissing: true});


lastRoute and screenShareRequest will alert during every refresh, even if logged in

userMetadata will alert if logged out

OSBotify · 2025-04-15T15:36:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-16T21:39:05Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.1.29-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fabioh8010 added 4 commits March 26, 2025 20:54

Bump Onyx to 2.0.95

3222ed4

Bump Expensify ESLint to 2.0.78

8b4a297

Enable provide-canBeMissing-in-useOnyx rule

e176d98

Display visual alert

7898916

fabioh8010 mentioned this pull request Mar 26, 2025

[CRITICAL] Add canBeMissing configuration option to useOnyx #58499

Open

Merge branch 'main' into feature/useOnyx-canBeMissing

93f5abb

CortneyOfstad mentioned this pull request Mar 28, 2025

[HOLD #58499][CRITICAL] Hold doesn't show in three dot menu until report is opened #52401

Open

8 tasks

Merge branch 'main' into feature/useOnyx-canBeMissing

029edb5

fabioh8010 mentioned this pull request Mar 28, 2025

Prevent "canBeMissing" alert if Onyx.clear() is in progress Expensify/react-native-onyx#624

Merged

42 tasks

Bump Onyx to 2.0.96

10dc598

fabioh8010 changed the title ~~[WIP] Bump Onyx / ESLint to match with useOnyx canBeMissing option~~ [HOLD react-native-onyx/pull/624] Bump Onyx / ESLint to match with useOnyx canBeMissing option Mar 28, 2025

fabioh8010 marked this pull request as ready for review March 28, 2025 19:20

fabioh8010 requested a review from a team as a code owner March 28, 2025 19:20

melvin-bot bot requested review from parasharrajat and removed request for a team March 28, 2025 19:20

fabioh8010 changed the title ~~[HOLD react-native-onyx/pull/624] Bump Onyx / ESLint to match with useOnyx canBeMissing option~~ [WIP][HOLD react-native-onyx/pull/624] Bump Onyx / ESLint to match with useOnyx canBeMissing option Mar 28, 2025

fabioh8010 added 2 commits April 2, 2025 07:24

Merge branch 'main' into feature/useOnyx-canBeMissing

6d29c21

Bump Onyx to 2.0.98

a8781a7

fabioh8010 changed the title ~~[WIP][HOLD react-native-onyx/pull/624] Bump Onyx / ESLint to match with useOnyx canBeMissing option~~ Bump Onyx / ESLint to match with useOnyx canBeMissing option Apr 2, 2025

TMisiukiewicz mentioned this pull request Apr 3, 2025

perf: create reportAttributes derived value #58476

Merged

51 tasks

fabioh8010 added 2 commits April 7, 2025 09:40

Merge branch 'main' into feature/useOnyx-canBeMissing

926b8f7

Append key string to the alert

5160138

TMisiukiewicz mentioned this pull request Apr 8, 2025

[Due for payment 2025-04-18] [$250] Use onyx derivedValue for more computation heavy report properties #59350

Open

fabioh8010 mentioned this pull request Apr 9, 2025

Bump react-native-onyx to 2.0.99 #59612

Merged

50 tasks

Merge branch 'main' into feature/useOnyx-canBeMissing

e0d7e67

fabioh8010 changed the title ~~Bump Onyx / ESLint to match with useOnyx canBeMissing option~~ Enable ESLint rule / DEV alert() to match with useOnyx canBeMissing option Apr 9, 2025

iwiznia previously approved these changes Apr 9, 2025

View reviewed changes

fabioh8010 added 2 commits April 13, 2025 21:05

Merge branch 'main' into feature/useOnyx-canBeMissing

81239b1

Add canBeMissing to Expensify.tsx useOnyx calls

e6acb78

fabioh8010 dismissed iwiznia’s stale review via e6acb78 April 13, 2025 20:14

fabioh8010 requested review from parasharrajat and iwiznia April 13, 2025 20:24

iwiznia reviewed Apr 14, 2025

View reviewed changes

fabioh8010 added 2 commits April 15, 2025 00:25

Merge branch 'main' into feature/useOnyx-canBeMissing

f03fe09

Minor typo

a6b0dfc

fabioh8010 requested a review from iwiznia April 14, 2025 23:37

iwiznia approved these changes Apr 15, 2025

View reviewed changes

parasharrajat approved these changes Apr 15, 2025

View reviewed changes

melvin-bot bot requested a review from iwiznia April 15, 2025 14:39

iwiznia approved these changes Apr 15, 2025

View reviewed changes

iwiznia merged commit 316a0d1 into Expensify:main Apr 15, 2025
26 checks passed

allgandalf mentioned this pull request Apr 16, 2025

Frontend: Private Domain Onboarding Check #54186

Merged

50 tasks

github-actions bot mentioned this pull request Apr 16, 2025

Deploy Checklist: New Expensify 2025-04-16 #60369

Open

83 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable ESLint rule / DEV alert() to match with useOnyx `canBeMissing` option #59191

Enable ESLint rule / DEV alert() to match with useOnyx `canBeMissing` option #59191

fabioh8010 commented Mar 26, 2025 •

edited

Loading

github-actions bot commented Mar 26, 2025

TMisiukiewicz commented Mar 27, 2025

github-actions bot commented Mar 28, 2025

melvin-bot bot commented Mar 28, 2025

fabioh8010 commented Mar 28, 2025

github-actions bot commented Apr 2, 2025

fabioh8010 commented Apr 2, 2025

parasharrajat commented Apr 2, 2025 •

edited

Loading

parasharrajat commented Apr 3, 2025 •

edited

Loading

parasharrajat commented Apr 3, 2025 •

edited

Loading

github-actions bot commented Apr 7, 2025

fabioh8010 commented Apr 7, 2025

fabioh8010 commented Apr 9, 2025

iwiznia commented Apr 9, 2025

iwiznia left a comment

parasharrajat commented Apr 9, 2025

iwiznia Apr 14, 2025

fabioh8010 Apr 14, 2025

iwiznia Apr 14, 2025

fabioh8010 Apr 14, 2025

OSBotify commented Apr 15, 2025

github-actions bot commented Apr 16, 2025

Enable ESLint rule / DEV alert() to match with useOnyx canBeMissing option #59191

Enable ESLint rule / DEV alert() to match with useOnyx canBeMissing option #59191

Conversation

fabioh8010 commented Mar 26, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

github-actions bot commented Mar 26, 2025

TMisiukiewicz commented Mar 27, 2025

github-actions bot commented Mar 28, 2025

melvin-bot bot commented Mar 28, 2025

fabioh8010 commented Mar 28, 2025

github-actions bot commented Apr 2, 2025

fabioh8010 commented Apr 2, 2025

parasharrajat commented Apr 2, 2025 • edited Loading

parasharrajat commented Apr 3, 2025 • edited Loading

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat commented Apr 3, 2025 • edited Loading

github-actions bot commented Apr 7, 2025

fabioh8010 commented Apr 7, 2025

fabioh8010 commented Apr 9, 2025

iwiznia commented Apr 9, 2025

iwiznia left a comment

Choose a reason for hiding this comment

parasharrajat commented Apr 9, 2025

iwiznia Apr 14, 2025

Choose a reason for hiding this comment

fabioh8010 Apr 14, 2025

Choose a reason for hiding this comment

iwiznia Apr 14, 2025

Choose a reason for hiding this comment

fabioh8010 Apr 14, 2025

Choose a reason for hiding this comment

OSBotify commented Apr 15, 2025

github-actions bot commented Apr 16, 2025

Enable ESLint rule / DEV alert() to match with useOnyx `canBeMissing` option #59191

Enable ESLint rule / DEV alert() to match with useOnyx `canBeMissing` option #59191

fabioh8010 commented Mar 26, 2025 •

edited

Loading

parasharrajat commented Apr 2, 2025 •

edited

Loading

parasharrajat commented Apr 3, 2025 •

edited

Loading

parasharrajat commented Apr 3, 2025 •

edited

Loading