-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[No QA] Update the adhoc build message to say a build was skipped and not failed #59847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Testing, no need for C+ review? |
🚧 @mountiny has triggered a test app build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
We also have Hybrid adhoc build. Does these changes also cover that? |
Can you run the build actions npm script |
@mountiny Is it @parasharrajat We don't build Standalone no more #59835. |
@mountiny I also think we should remove this row from the result table. It might have been used to separate Standalone & HybridApp builds. |
Seems like it did not really work, right? |
@mountiny I found the fix. Can you trigger the adhoc build? |
🚧 @mountiny has triggered a test app build. You can view the workflow run here. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Still it does not seem like it posted the right messages |
cc @mountiny to trigger adhoc builds
Explanation of Change
Fixed Issues
$ #59843
PROPOSAL: #59843 (comment)
Tests
None
Offline tests
None
QA Steps
None
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop