[NoQA] Add `CSpell` for spelling checks [Part 1] #60385

dominictb · 2025-04-17T00:23:48Z

Explanation of Change

Fix spells in all folders and top-level files except src/ and tests/ folders. Github Action for CSpell has not been integrated here.

Fixed Issues

$ #54810
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2025-04-17T00:23:59Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

…eat/54810-1

melvin-bot · 2025-04-17T01:18:38Z

melvin-bot · 2025-04-17T01:18:41Z

@Valforte @CortneyOfstad One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Valforte

Only one observation, and need to check ESLint exception

...y-classic/getting-started/playbooks/Expensify-Playbook-For-US-Based-Bootstrapped-Startups.md

melvin-bot · 2025-04-17T17:23:37Z

Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work?

mountiny · 2025-04-17T17:30:23Z

src/pages/home/report/ReportDetailsExportPage.tsx

I dont think we have to do the eslint check here as we already touched a lot of files

mountiny · 2025-04-17T17:43:36Z

docs/articles/expensify-classic/connections/netsuite/Configure-Netsuite.md

@@ -60,7 +60,7 @@ This dictates when reimbursable expenses will export, according to your preferre

 ## Export Settings for Reimbursable Expenses 

-**Expense Reports:** Expensify transactions will export reimbursable expenses as expense reports by default, which will be posted to the payables account designated in NetSuite. 


@CortneyOfstad Can you confirm please, this sounds right to me, but would be great to get a double check. Thanks!

@CortneyOfstad Can you help to confirm?

mountiny · 2025-04-17T17:44:08Z

docs/articles/expensify-classic/connections/netsuite/Configure-Netsuite.md

@@ -496,7 +496,7 @@ If you have confirmed that your categories are set as Expense Categories in NetS
 ## What's the difference between a Custom Segment, Custom Record, and Custom List?

 - **Custom Record**: This is an entirely customizable record type used to store detailed, structured information not covered by standard NetSuite records (e.g., customers, vendors, and transactions). Unlike Segments, Custom Records are designed to manage standalone data, like tracking projects, assets, or other entities.
- **Custom Segment**: A custom classification field similar to standard NetSuite segments like Department, Class, or Location. Typically used when you need to categorize transactions, records, or GL entries for reporting purposes or to separate financials. (NetSuite automatically creates a Custom Record behind the scenes to power the segment.)
+- **Custom Segment**: A custom classification field similar to standard NetSuite segments like Department, Class, or Location. Typically used when you need to categorize transactions, records, or GL entries for reporting purposes or to separate financial. (NetSuite automatically creates a Custom Record behind the scenes to power the segment.)


I feel like financials is right here cc @CortneyOfstad

What's the conclusion? @CortneyOfstad

mountiny · 2025-04-17T17:44:22Z

docs/articles/expensify-classic/expenses/Add-an-expense.md

@@ -1,11 +1,11 @@
 ---
 title: add-an-expense.md
-description: Learn how to add, edit, and manage expenses in Expensify, including SmartScans, per diems, mileage, and group expenses.
+description: Learn how to add, edit, and manage expenses in Expensify, including SmartScans, per diem, mileage, and group expenses.


plural is good here too

docs/articles/expensify-classic/expenses/Add-an-expense.md

docs/articles/expensify-classic/workspaces/Configure-Reimbursement-Settings.md

Co-authored-by: Vit Horacek <[email protected]>

mountiny · 2025-04-19T14:45:14Z

@dominictb couple of requested changes, can you please address them?

@ishpaul777 can you also review please

ishpaul777 · 2025-04-20T19:27:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Uploading Screen Recording 2025-04-22 at 3.14.15 PM.mov…

Android: mWeb Chrome

Screen.Recording.2025-04-21.at.2.06.27.AM.mov

iOS: Native

Screen.Recording.2025-04-21.at.2.32.18.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-04-21.at.2.02.56.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-21.at.2.01.46.AM.mov

MacOS: Desktop

Screen.Recording.2025-04-22.at.3.28.30.PM.mov

ishpaul777 · 2025-04-20T21:22:55Z

It LGTM! just resolve conflicts please @dominic

…eat/54810-1

…p into feat/54810-1

dominictb · 2025-04-21T16:02:51Z

@ishpaul777 @mountiny All checked!

ishpaul777

looks good!

docs/articles/expensify-classic/expenses/Add-an-expense.md

Co-authored-by: Vit Horacek <[email protected]>

mountiny · 2025-04-22T16:21:13Z

As this is a large PR updating many files, we are not going to update the optional ESLint change here - not emergency

Addressed

mountiny · 2025-04-22T16:21:57Z

As there is high potential of a conflict, I am going to merge now

melvin-bot · 2025-04-22T16:22:14Z

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

mountiny · 2025-04-22T16:22:28Z

Explained above

OSBotify · 2025-04-22T16:30:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-23T18:45:21Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.32-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix spells except src/ and tests/ folders

95ec76c

Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into f…

7a4c10a

…eat/54810-1

dominictb marked this pull request as ready for review April 17, 2025 01:18

dominictb requested review from a team as code owners April 17, 2025 01:18

melvin-bot bot requested review from CortneyOfstad and Valforte and removed request for a team April 17, 2025 01:18

Valforte previously requested changes Apr 17, 2025

View reviewed changes

...y-classic/getting-started/playbooks/Expensify-Playbook-For-US-Based-Bootstrapped-Startups.md Outdated Show resolved Hide resolved

mountiny assigned dominictb Apr 17, 2025

mountiny requested review from mountiny and removed request for a team April 17, 2025 17:22

mountiny changed the title ~~Add CSpell for spelling checks [Part 1]~~ [NoQA] Add CSpell for spelling checks [Part 1] Apr 17, 2025

mountiny reviewed Apr 17, 2025

View reviewed changes

mountiny requested changes Apr 17, 2025

View reviewed changes

Update docs/articles/expensify-classic/expenses/Add-an-expense.md

4f3e80f

Co-authored-by: Vit Horacek <[email protected]>

mountiny requested a review from ishpaul777 April 19, 2025 14:45

dominictb added 3 commits April 21, 2025 22:53

Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into f…

ac2c8b5

…eat/54810-1

Merge branch 'feat/54810-1' of github.com-dominictb:dominictb/epsf-ap…

d96c189

…p into feat/54810-1

feedbacks

b7b681a

ishpaul777 approved these changes Apr 22, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny April 22, 2025 10:12

mountiny reviewed Apr 22, 2025

View reviewed changes

docs/articles/expensify-classic/expenses/Add-an-expense.md Outdated Show resolved Hide resolved

diem to diems

b686c38

Co-authored-by: Vit Horacek <[email protected]>

mountiny approved these changes Apr 22, 2025

View reviewed changes

mountiny requested a review from Valforte April 22, 2025 16:21

mountiny merged commit 6bd84d7 into Expensify:main Apr 22, 2025
26 of 27 checks passed

melvin-bot bot added the Emergency label Apr 22, 2025

mountiny removed the Emergency label Apr 22, 2025

github-actions bot mentioned this pull request Apr 23, 2025

Deploy Checklist: New Expensify 2025-04-23 #60729

Open

90 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NoQA] Add `CSpell` for spelling checks [Part 1] #60385

[NoQA] Add `CSpell` for spelling checks [Part 1] #60385

dominictb commented Apr 17, 2025 •

edited

Loading

github-actions bot commented Apr 17, 2025

melvin-bot bot commented Apr 17, 2025

melvin-bot bot commented Apr 17, 2025

Valforte left a comment

melvin-bot bot commented Apr 17, 2025

mountiny Apr 17, 2025

mountiny Apr 17, 2025

dominictb Apr 21, 2025

mountiny Apr 17, 2025

dominictb Apr 21, 2025

mountiny Apr 17, 2025

mountiny commented Apr 19, 2025

ishpaul777 commented Apr 20, 2025 •

edited

Loading

ishpaul777 commented Apr 20, 2025

dominictb commented Apr 21, 2025

ishpaul777 left a comment

mountiny commented Apr 22, 2025

mountiny commented Apr 22, 2025

melvin-bot bot commented Apr 22, 2025

mountiny commented Apr 22, 2025

OSBotify commented Apr 22, 2025

github-actions bot commented Apr 23, 2025

		@@ -60,7 +60,7 @@ This dictates when reimbursable expenses will export, according to your preferre

		## Export Settings for Reimbursable Expenses

		Expense Reports: Expensify transactions will export reimbursable expenses as expense reports by default, which will be posted to the payables account designated in NetSuite.

[NoQA] Add CSpell for spelling checks [Part 1] #60385

[NoQA] Add CSpell for spelling checks [Part 1] #60385

Conversation

dominictb commented Apr 17, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

github-actions bot commented Apr 17, 2025

melvin-bot bot commented Apr 17, 2025

Concierge reviewer checklist:

melvin-bot bot commented Apr 17, 2025

Valforte left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Apr 17, 2025

mountiny Apr 17, 2025

Choose a reason for hiding this comment

mountiny Apr 17, 2025

Choose a reason for hiding this comment

dominictb Apr 21, 2025

Choose a reason for hiding this comment

mountiny Apr 17, 2025

Choose a reason for hiding this comment

dominictb Apr 21, 2025

Choose a reason for hiding this comment

mountiny Apr 17, 2025

Choose a reason for hiding this comment

mountiny commented Apr 19, 2025

ishpaul777 commented Apr 20, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

ishpaul777 commented Apr 20, 2025

dominictb commented Apr 21, 2025

ishpaul777 left a comment

Choose a reason for hiding this comment

mountiny commented Apr 22, 2025

mountiny commented Apr 22, 2025

melvin-bot bot commented Apr 22, 2025

mountiny commented Apr 22, 2025

OSBotify commented Apr 22, 2025

github-actions bot commented Apr 23, 2025

[NoQA] Add `CSpell` for spelling checks [Part 1] #60385

[NoQA] Add `CSpell` for spelling checks [Part 1] #60385

dominictb commented Apr 17, 2025 •

edited

Loading

ishpaul777 commented Apr 20, 2025 •

edited

Loading