perf: move report brick road statuses to a derived value #60827
There are no files selected for viewing
Submodule Mobile-Expensify
updated
from fb1790 to 0ffb7b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ import type {ValueOf} from 'type-fest'; | |
| import type {PartialPolicyForSidebar} from '@hooks/useSidebarOrderedReportIDs'; | ||
| import CONST from '@src/CONST'; | ||
| import ONYXKEYS from '@src/ONYXKEYS'; | ||
| import type {PersonalDetails, PersonalDetailsList, ReportActions, ReportAttributes, ReportNameValuePairs, TransactionViolation} from '@src/types/onyx'; | ||
| import type Beta from '@src/types/onyx/Beta'; | ||
| import type Policy from '@src/types/onyx/Policy'; | ||
| import type PriorityMode from '@src/types/onyx/PriorityMode'; | ||
|
|
@@ -163,6 +163,14 @@ Onyx.connect({ | |
| }, | ||
| }); | ||
|
|
||
| let reportAttributes: OnyxEntry<Record<string, ReportAttributes>>; | ||
| Onyx.connect({ | ||
| key: ONYXKEYS.DERIVED.REPORT_ATTRIBUTES, | ||
| callback: (value) => { | ||
| reportAttributes = value; | ||
| }, | ||
| }); | ||
|
|
||
| function compareStringDates(a: string, b: string): 0 | 1 | -1 { | ||
| if (a < b) { | ||
| return -1; | ||
|
|
@@ -340,6 +348,47 @@ type ReasonAndReportActionThatHasRedBrickRoad = { | |
| reportAction?: OnyxEntry<ReportAction>; | ||
| }; | ||
|
|
||
| function hasAnyErrorsOrViolations(report: Report, reportActions: OnyxEntry<ReportActions>, hasAnyViolations: boolean, hasErrors: boolean, singleTransactionThread?: string) { | ||
| const {reportAction} = getAllReportActionsErrorsAndReportActionThatRequiresAttention(report, reportActions); | ||
| if (isArchivedReportWithID(report.reportID)) { | ||
| return false; | ||
| } | ||
|
|
||
| if (hasAnyViolations) { | ||
| return { | ||
| reason: CONST.RBR_REASONS.HAS_TRANSACTION_THREAD_VIOLATIONS, | ||
| }; | ||
| } | ||
|
|
||
| if (hasErrors) { | ||
| return { | ||
| reason: CONST.RBR_REASONS.HAS_ERRORS, | ||
| reportAction, | ||
| }; | ||
| } | ||
|
|
||
| if (singleTransactionThread) { | ||
| const transactionID = getTransactionID(singleTransactionThread); | ||
| const transaction = getTransaction(transactionID); | ||
| if (hasReceiptError(transaction)) { | ||
| return { | ||
| reason: CONST.RBR_REASONS.HAS_ERRORS, | ||
| }; | ||
| } | ||
| } | ||
|
|
||
| const parentReportAction = getReportAction(report?.parentReportID, report?.parentReportActionID); | ||
| const transactionID = getTransactionID(report.reportID); | ||
| const transaction = getTransaction(transactionID); | ||
| if (isTransactionThread(parentReportAction) && hasReceiptError(transaction)) { | ||
| return { | ||
| reason: CONST.RBR_REASONS.HAS_ERRORS, | ||
| }; | ||
| } | ||
|
|
||
| return false; | ||
| } | ||
|
|
||
| function getReasonAndReportActionThatHasRedBrickRoad( | ||
| report: Report, | ||
| reportActions: OnyxEntry<ReportActions>, | ||
|
|
@@ -410,9 +459,7 @@ function getOptionData({ | |
| preferredLocale, | ||
| policy, | ||
| parentReportAction, | ||
| lastMessageTextFromReport: lastMessageTextFromReportProp, | ||
| invoiceReceiverPolicy, | ||
| }: { | ||
| report: OnyxEntry<Report>; | ||
|
|
@@ -423,10 +470,8 @@ function getOptionData({ | |
| preferredLocale: DeepValueOf<typeof CONST.LOCALES>; | ||
| policy: OnyxEntry<Policy> | undefined; | ||
| parentReportAction: OnyxEntry<ReportAction> | undefined; | ||
| lastMessageTextFromReport?: string; | ||
| invoiceReceiverPolicy?: OnyxEntry<Policy>; | ||
| }): OptionData | undefined { | ||
| // When a user signs out, Onyx is cleared. Due to the lazy rendering with a virtual list, it's possible for | ||
| // this method to be called after the Onyx data has been cleared out. In that case, it's fine to do | ||
|
|
@@ -485,7 +530,7 @@ function getOptionData({ | |
| result.isMoneyRequestReport = isMoneyRequestReport(report); | ||
| result.shouldShowSubscript = shouldReportShowSubscript(report); | ||
| result.pendingAction = report.pendingFields?.addWorkspaceRoom ?? report.pendingFields?.createChat; | ||
| result.brickRoadIndicator = reportAttributes?.[report.reportID]?.brickRoadStatus; | ||
|
There was a problem hiding this comment. Is it possible to use There was a problem hiding this comment. I think Screen.Recording.2025-04-30.at.16.17.26.movSo I'll update the PR and remove There was a problem hiding this comment. Ok after double-checking I tried different approach: Instead of passing all report attributes, I am passing only the one related to the item to |
||
| result.ownerAccountID = report.ownerAccountID; | ||
| result.managerID = report.managerID; | ||
| result.reportID = report.reportID; | ||
|
|
@@ -679,7 +724,6 @@ function getOptionData({ | |
|
|
||
| if (isJoinRequestInAdminRoom(report)) { | ||
| result.isUnread = true; | ||
|
There was a problem hiding this comment. Have we migrated this logic to |
||
| } | ||
|
|
||
| if (!hasMultipleParticipants) { | ||
|
|
@@ -824,4 +868,5 @@ export default { | |
| getWelcomeMessage, | ||
| getReasonAndReportActionThatHasRedBrickRoad, | ||
| shouldShowRedBrickRoad, | ||
| hasAnyErrorsOrViolations, | ||
| }; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's incorrect because it should be retrieved in
reportActionsof parent reportApp/src/components/LHNOptionsList/LHNOptionsList.tsx
Lines 138 to 139 in 497cdce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, thanks!