Skip to content

Comments

chore: Update TextInput onPaste event to allow multiple files on iOS#753

Merged
war-in merged 3 commits intoExpensify:mainfrom
margelo:@chrispader/onPaste-multifile-support
Feb 19, 2026
Merged

chore: Update TextInput onPaste event to allow multiple files on iOS#753
war-in merged 3 commits intoExpensify:mainfrom
margelo:@chrispader/onPaste-multifile-support

Conversation

@chrispader
Copy link
Contributor

@chrispader chrispader commented Feb 18, 2026

Details

Needed for Expensify/App#68551

Updates the iOS textInputDidPaste delegate method to allow passing multiple items.

Related Issues

Expensify/App#68551

Manual Tests

Refer to Expensify/App#68551

Linked PRs

Copy link
Collaborator

@war-in war-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will that change work with the current E/App setup, or are changes from the linked PR required? If so, live-markdown updates will be blocked on this particular E/App PR

@chrispader
Copy link
Contributor Author

Will that change work with the current E/App setup, or are changes from the linked PR required? If so, live-markdown updates will be blocked on this particular E/App PR

@war-in yes, we'll need to bump the react-native-live-markdown version together with the changes in Expensify/App#68551 or otherwise in a coordinated way, otherwise there will be issues.

@tomekzaw
Copy link
Collaborator

Can we just add - (void)textInputDidPaste: method while keeping - (void)textInputDidPaste:withData: for backwards compatibility?

@chrispader
Copy link
Contributor Author

chrispader commented Feb 19, 2026

Can we just add - (void)textInputDidPaste: method while keeping - (void)textInputDidPaste:withData: for backwards compatibility?

@tomekzaw @war-in yes that works. Just tested it locally and it worked smoothly. Updated the PR

@war-in
Copy link
Collaborator

war-in commented Feb 19, 2026

Great! Merging then (after all checks pass), thank you!

@chrispader
Copy link
Contributor Author

@war-in let's wait with merge for @mountiny's opinion on the affected PR 🙌🏼

@mountiny
Copy link

Yeah feel free to merge!

@war-in war-in merged commit 5ebd752 into Expensify:main Feb 19, 2026
7 checks passed
@os-botify
Copy link
Contributor

os-botify bot commented Feb 19, 2026

🚀 Published to npm in 0.1.324 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants