Fix picker still avoiding view when the picker itself is unmounted #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PickerAvoidingView is added in this PR to make sure the input that triggers the picker is not covered by the picker modal itself, similar to what KeyboardAvoidingView is doing.
It works by maintaining the picker modal visibility state in a context. However, the handling of the state does not take into account if the picker itself is unmounted from the screen resulting in the visibility state being stuck at
true
.Test plan
Use this branch/commit and test if the issue at Expensify/App#23044 is resolved.
Test step:
Screen.Recording.2023-07-20.at.13.13.21.mov