Skip to content

Fix pipeline batch parent finalization - #2181

Merged
chubes4 merged 2 commits into
mainfrom
fix/issue-2180-child-finalization
May 22, 2026
Merged

Fix pipeline batch parent finalization#2181
chubes4 merged 2 commits into
mainfrom
fix/issue-2180-child-finalization

Conversation

@chubes4

@chubes4 chubes4 commented May 22, 2026

Copy link
Copy Markdown
Member

Summary

  • Rechecks pipeline batch parent completion after the final batch chunk so fully terminal children cannot leave the parent stuck in processing with no future scheduler owner.
  • Makes jobs liveness batch-aware by counting pipeline batch chunk actions and active child jobs as scheduler paths instead of reporting them as no_scheduler_path.
  • Covers the missed-finalization gap with a focused batch scheduler unit test and updates the liveness smoke test for batch ownership.

Fixes #2180.

Verification

  • php -l inc/Abilities/Engine/PipelineBatchScheduler.php
  • php -l inc/Cli/Commands/JobsCommand.php
  • php -l tests/Unit/Abilities/Engine/PipelineBatchSchedulerTest.php && php -l tests/job-liveness-cli-smoke.php
  • php tests/job-liveness-cli-smoke.php
  • vendor/bin/phpcs inc/Abilities/Engine/PipelineBatchScheduler.php inc/Cli/Commands/JobsCommand.php tests/Unit/Abilities/Engine/PipelineBatchSchedulerTest.php tests/job-liveness-cli-smoke.php
  • homeboy test --path /Users/chubes/Developer/data-machine@fix-issue-2180-child-finalization --extension wordpress --filter PipelineBatchSchedulerTest passed: 1288 tests, 1285 passed, 3 skipped.

Notes

  • vendor/bin/phpunit tests/Unit/Abilities/Engine/PipelineBatchSchedulerTest.php could not run because vendor/bin/phpunit is not present in this checkout; Homeboy WP Codebox was used for PHPUnit verification.
  • homeboy lint --path /Users/chubes/Developer/data-machine@fix-issue-2180-child-finalization --extension wordpress --force-hot still reports pre-existing admin React lint findings outside the touched files.

AI assistance

@homeboy-ci

homeboy-ci Bot commented May 22, 2026

Copy link
Copy Markdown
Contributor

Homeboy Results — data-machine

Lint

lint — passed

ℹ️ Full options: homeboy docs commands/lint
Deep dive: homeboy lint data-machine --changed-since 40cc9b1

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26310484908

Test

test — passed

  • 41 passed

ℹ️ Auto-fix lint issues: homeboy refactor data-machine --from lint --write
ℹ️ Collect coverage: homeboy test data-machine --coverage
ℹ️ Save test baseline: homeboy test data-machine --baseline
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine --changed-since 40cc9b1

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26310484908

Audit

audit — passed

  • dead_code — 151 finding(s)
  • requested_detectors — 126 finding(s)
  • intra-method-duplication — 66 finding(s)
  • repeated_literal_shape — 13 finding(s)
  • field_patterns — 9 finding(s)
  • Taxonomy — 5 finding(s)
  • structural — 5 finding(s)
  • Abilities — 4 finding(s)
  • Flow — 4 finding(s)
  • File — 2 finding(s)
  • Total: 395 finding(s)

Deep dive: homeboy audit data-machine --changed-since 40cc9b1

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26310484908
Tooling versions
  • Homeboy CLI: homeboy 0.197.2+51ec8b6b
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: dd23ee80
  • Action: unknown@unknown

@chubes4
chubes4 merged commit 4cbb958 into main May 22, 2026
5 checks passed
@chubes4
chubes4 deleted the fix/issue-2180-child-finalization branch May 22, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate processing child jobs with no scheduler path

1 participant