Fix pipeline batch parent finalization - #2181
Merged
Merged
Conversation
Contributor
Homeboy Results —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
processingwith no future scheduler owner.jobs livenessbatch-aware by counting pipeline batch chunk actions and active child jobs as scheduler paths instead of reporting them asno_scheduler_path.Fixes #2180.
Verification
php -l inc/Abilities/Engine/PipelineBatchScheduler.phpphp -l inc/Cli/Commands/JobsCommand.phpphp -l tests/Unit/Abilities/Engine/PipelineBatchSchedulerTest.php && php -l tests/job-liveness-cli-smoke.phpphp tests/job-liveness-cli-smoke.phpvendor/bin/phpcs inc/Abilities/Engine/PipelineBatchScheduler.php inc/Cli/Commands/JobsCommand.php tests/Unit/Abilities/Engine/PipelineBatchSchedulerTest.php tests/job-liveness-cli-smoke.phphomeboy test --path /Users/chubes/Developer/data-machine@fix-issue-2180-child-finalization --extension wordpress --filter PipelineBatchSchedulerTestpassed: 1288 tests, 1285 passed, 3 skipped.Notes
vendor/bin/phpunit tests/Unit/Abilities/Engine/PipelineBatchSchedulerTest.phpcould not run becausevendor/bin/phpunitis not present in this checkout; Homeboy WP Codebox was used for PHPUnit verification.homeboy lint --path /Users/chubes/Developer/data-machine@fix-issue-2180-child-finalization --extension wordpress --force-hotstill reports pre-existing admin React lint findings outside the touched files.AI assistance