Skip to content

Require handler completion before natural finish - #2184

Merged
chubes4 merged 1 commit into
mainfrom
fix-handler-natural-completion
May 22, 2026
Merged

Require handler completion before natural finish#2184
chubes4 merged 1 commit into
mainfrom
fix-handler-natural-completion

Conversation

@chubes4

@chubes4 chubes4 commented May 22, 2026

Copy link
Copy Markdown
Member

Summary

  • Keep pipeline conversations incomplete when configured adjacent handlers have not completed yet, even if the assistant naturally finishes.
  • Report remaining handler slugs in the completion decision context so missing handler handoffs stay diagnosable.
  • Add smoke coverage for natural completion before wiki_upsert runs.

Verification

  • php tests/agent-conversation-runtime-policy-smoke.php
  • php -l inc/Engine/AI/DataMachineHandlerCompletionPolicy.php && php -l tests/agent-conversation-runtime-policy-smoke.php
  • homeboy test --path /Users/chubes/Developer/data-machine@fix-handler-natural-completion --extension wordpress

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (GPT-5.5)
  • Used for: Diagnosed the handler completion policy gap, drafted the targeted fix and smoke coverage, and ran verification for Chris to review.

@homeboy-ci

homeboy-ci Bot commented May 22, 2026

Copy link
Copy Markdown
Contributor

Homeboy Results — data-machine

Lint

lint — passed

ℹ️ Full options: homeboy docs commands/lint
Deep dive: homeboy lint data-machine --changed-since d2de5df

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26309288476

Test

test — passed

ℹ️ Auto-fix lint issues: homeboy refactor data-machine --from lint --write
ℹ️ Collect coverage: homeboy test data-machine --coverage
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine --changed-since d2de5df

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26309288476

Audit

audit — passed

  • intra-method-duplication — 1 finding(s)
  • Total: 1 finding(s)

Deep dive: homeboy audit data-machine --changed-since d2de5df

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26309288476
Tooling versions
  • Homeboy CLI: homeboy 0.197.2+e93db93a
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: dd23ee80
  • Action: unknown@unknown

@chubes4
chubes4 merged commit 8f1ab99 into main May 22, 2026
5 checks passed
@chubes4
chubes4 deleted the fix-handler-natural-completion branch May 22, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant