Conversation
Clears the WordPress-Extra PHPCS gate (homeboy release preflight) which was failing on pre-existing tech debt unrelated to any feature work. Auto-fixed via phpcbf (formatting only, no behavior change): - Missing newline at EOF (admin-customizations.php, co-authors.php) - Array double-arrow alignment + trailing multiline commas (co-authors.php) - Multi-line function-call arg wrapping (co-authors.php) Hand-fixed real errors: - section-3x3-grid.php: rename local $title -> $item_title to stop overriding the WP $title global (GlobalVariablesOverride, x2) - ads-filter.php: Yoda condition (1 !== (int) blog_id) - login-register-cta.php: annotate do_blocks() output with phpcs:ignore (trusted core-rendered block markup that must not be escaped) No false positives found; homeboy lint scope (WordPress-Extra, vendor excluded) is correct, so no homeboy issue filed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears the PHPCS preflight gate that
homeboy release extrachill-blog --applyruns, which was failing on pre-existing tech debt (~10 errors) unrelated to any recent feature and blocking release of already-merged work.Verified against homeboy's exact gate ruleset (
WordPress-Extra, PHP 7.4+,--warning-severity=0, vendor/build/dist/tests excluded): 0 errors, 0 warnings.No false positives — no homeboy issue filed
Triage confirmed homeboy's lint scope is correct: it uses
WordPress-Extraand already excludesvendor/,node_modules/,build/,dist/,tests/. Every flagged error was in first-partyinc/code. Nothing to file upstream.Auto-fixed via
phpcbf(formatting only, behavior-preserving)admin-customizations.php,co-authors.phpco-authors.phpco-authors.phpHand-fixed real errors
inc/home/templates/section-3x3-grid.php(×2)WordPress.WP.GlobalVariablesOverride$title→$item_titleso the loop no longer clobbers WP's$titleglobalinc/core/ads-filter.phpWordPress.PHP.YodaConditions(int) $context['blog_id'] !== 1→1 !== (int) $context['blog_id']inc/single/login-register-cta.phpWordPress.Security.EscapeOutputphpcs:ignorewith justification ondo_blocks()— it returns trusted, core-rendered block markup that must not be escaped (escaping would break the block HTML)Verification
php -lclean on all 5 touched filesERRORS: 0 WARNINGS: 0$wpdbuntouched (none of the errors involved SQL)PR only — not merged, not released.