fix(runs): keep terminal Lab artifact reads local - #11942
Merged
Conversation
Terminal artifact and evidence readers now use only persisted controller state, while generated public URLs require recorded reachability before emission. AI assistance: OpenAI gpt-5.6-sol via OpenCode was used to trace the artifact-reader and publication paths, implement the bounded-read invariant, and run focused verification. Chris Huber remains responsible for every line.
Contributor
Homeboy Results —
|
added 2 commits
August 8, 2026 03:34
Legacy artifact records without public_url_validation retain their persisted public and viewer links. Newly persisted generated URLs are validation-stamped and only emitted when their recorded reachability proof succeeds. AI assistance: OpenAI gpt-5.6-sol via OpenCode was used to trace the persisted artifact compatibility boundary, implement the tri-state validation contract, add migration coverage, and run verification. Chris Huber remains responsible for every line.
Populate the hidden release readiness input in self-check command arguments so every workspace test target and CI shard planner compile against the current CLI contract. AI assistance: OpenAI gpt-5.6-terra via OpenCode inspected the CI failures, restored the test command argument contract, and ran workspace compilation plus focused tests. Chris Huber remains responsible for every line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10891.
Summary
runs artifact getrecovery path available when public publication is unavailableInvariant
Successful terminal handoffs never emit an unverified generated public artifact URL.
runs artifactsandruns evidencedo not acquire the runner-provider lock, so a disconnected or stuck runner cannot block durable local metadata reads.Verification
cargo test -p homeboy-core require_run_reads_terminal_lab_review_alias_while_runner_probe_is_stalled --libcargo test -p homeboy-cli artifacts_command_suppresses_viewer_links_when_public_url_is_unreachable --libcargo check -p homeboy-core -p homeboy-cli -p homeboy-extensioncargo fmt --all --checkgit diff --checkPerformance Bounds
AI assistance
AI assistance: OpenAI gpt-5.6-sol via OpenCode was used to trace the artifact-reader and publication paths, implement the bounded-read invariant, and run focused verification. Chris Huber remains responsible for every line.