Skip to content

Route review-form timeouts to Cook continuation - #11998

Closed
chubes4 wants to merge 1 commit into
mainfrom
fix/11980-illegal-retry-guidance
Closed

Route review-form timeouts to Cook continuation#11998
chubes4 wants to merge 1 commit into
mainfrom
fix/11980-illegal-retry-guidance

Conversation

@chubes4

@chubes4 chubes4 commented Aug 8, 2026

Copy link
Copy Markdown
Member

Summary

  • detect timed-out review-form attempts through the same immutable recipe-attempt contract as cook-continue
  • suppress illegal generic retry guidance and emit the authenticated continuation command
  • fail closed when recipe lookup or continuation eligibility cannot be established

Verification

Closes #11980

AI Assistance

OpenAI gpt-5.6-sol via OpenCode implemented, tested, and reviewed this repair under human direction. Chris Huber remains responsible for every line.

@homeboy-ci

homeboy-ci Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Homeboy Results — homeboy

Lint

review lint — passed

ℹ️ Full options: homeboy self docs commands/lint
ℹ️ Save lint baseline: homeboy review lint homeboy --baseline
Deep dive: homeboy review lint homeboy --changed-since 66a6691

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-homeboy-review-lint-homeboy-fast-Linux contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-homeboy-review-lint-homeboy-fast-Linux contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/homeboy/actions/runs/31281169916

Audit

⚠️ review audit — no measurement

Deep dive: homeboy review audit homeboy --changed-since 66a6691

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-homeboy-review-audit-homeboy-fast-Linux contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-homeboy-review-audit-homeboy-fast-Linux contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/homeboy/actions/runs/31281169916
Tooling versions
  • Homeboy CLI: homeboy 0.334.0+1b3788fed86c-dirty
  • Extension: rust from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: a32e4ea3
  • Action: unknown@unknown

@chubes4

chubes4 commented Aug 9, 2026

Copy link
Copy Markdown
Member Author

Superseded by #12012, which landed review-timeout continuation routing on main. AI assistance disclosure: OpenAI gpt-5.6-sol via OpenCode was used to verify patch equivalence and reconcile the PR queue.

@chubes4 chubes4 closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Diagnose recommends an illegal generic retry after review-form timeout

1 participant