Skip to content

Prune stale audit baseline paths after source removal - #12005

Closed
chubes4 wants to merge 2 commits into
mainfrom
fix/issue-12004-stale-audit-baselines
Closed

Prune stale audit baseline paths after source removal#12005
chubes4 wants to merge 2 commits into
mainfrom
fix/issue-12004-stale-audit-baselines

Conversation

@chubes4

@chubes4 chubes4 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • remove the core-boundary fingerprint for deleted crates/homeboy-core/src/local_permissions.rs
  • remove the structural fingerprint for deleted crates/homeboy-core/src/report_compare.rs
  • preserve every live, directory-scoped, and synthetic baseline row unchanged

Verification

  • exact recorded source paths are absent from the current tree
  • full local review audit --placement local --json-summary advanced past stale-baseline validation and ran detectors; the expensive full run exceeded the 20-minute local tool timeout before terminal findings
  • git diff --check

Closes #12004.

AI Assistance

OpenAI gpt-5.6-sol via OpenCode isolated the stale rows from the full Audit run, verified their exact paths were absent, and implemented the bounded baseline repair under human direction. Chris Huber remains responsible for every line.

@homeboy-ci

homeboy-ci Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Homeboy Results — homeboy

Lint

review lint — passed

ℹ️ Full options: homeboy self docs commands/lint
ℹ️ Save lint baseline: homeboy review lint homeboy --baseline
Deep dive: homeboy review lint homeboy --changed-since 66a6691

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-homeboy-review-lint-homeboy-fast-Linux contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-homeboy-review-lint-homeboy-fast-Linux contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/homeboy/actions/runs/31293722822

Audit

⚠️ review audit — baseline red

  • structural — 99 finding(s)
  • core_boundary_leak:core-agnostic-source — 89 finding(s)
  • constant_bypass_literal — 45 finding(s)
  • dead_code — 33 finding(s)
  • intra-method-duplication — 32 finding(s)
  • skeleton-duplication — 25 finding(s)
  • output_capture — 15 finding(s)
  • near-duplication — 12 finding(s)
  • thin_command_adapter — 8 finding(s)
  • parallel-implementation — 7 finding(s)
  • Total: 398 finding(s)

Deep dive: homeboy review audit homeboy --changed-since 66a6691

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-homeboy-review-audit-homeboy-fast-Linux contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-homeboy-review-audit-homeboy-fast-Linux contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/homeboy/actions/runs/31293722822
Tooling versions
  • Homeboy CLI: homeboy 0.334.0+029bfcc6adbb-dirty
  • Extension: rust from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: 8f471080
  • Action: unknown@unknown

@chubes4

chubes4 commented Aug 9, 2026

Copy link
Copy Markdown
Member Author

CI prerequisite update: this branch now includes the existing one-line AdoptArgs fixture commit from #11996 so current main can compile workspace tests and reach the Audit gate. The audit repair itself remains only the two stale baseline deletions; the prerequisite diff disappears when #11996 lands.

AI assistance: OpenAI gpt-5.6-sol via OpenCode identified and applied the existing prerequisite under human direction. Chris Huber remains responsible for the branch.

@chubes4

chubes4 commented Aug 9, 2026

Copy link
Copy Markdown
Member Author

Superseded by #12012, which landed the stale audit fingerprint repairs on main. AI assistance disclosure: OpenAI gpt-5.6-sol via OpenCode was used to verify patch equivalence and reconcile the PR queue.

@chubes4 chubes4 closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prune stale audit baseline paths after source removal

1 participant