Skip to content

refactor: plan Lab path materialization - #7853

Merged
chubes4 merged 2 commits into
mainfrom
refactor/7705-path-materialization-planner
Jul 12, 2026
Merged

refactor: plan Lab path materialization#7853
chubes4 merged 2 commits into
mainfrom
refactor/7705-path-materialization-planner

Conversation

@chubes4

@chubes4 chubes4 commented Jul 12, 2026

Copy link
Copy Markdown
Member

Summary

  • Consolidate Lab controller-side path discovery into PathMaterializationPlanner, evaluated before remote workspace mutation and consumed once by workspace staging.
  • Add additive config_path_fields declarations to extension agent-runtime manifests and carry them into the runtime catalog; provider-config validation honors declared fields.
  • Persist RunnerExecutionRecord transition snapshots for daemon and reverse-broker planned, running, and terminal states, including job watch/follow/cancel actions.

Diffstat

  • 10 files changed, 488 insertions(+), 247 deletions(-)

Fixes #7705

Planner design

The planner resolves workspace refs and aggregates provider configuration, agent-task plans and fanout, runtime components, settings, rig-declared passthrough inputs, refresh/extension sources, overlays, and rig component environment paths before staging. Workspace staging consumes its resolved argv and workspace list, eliminating the former post-remap path-setting re-scan.

Parity coverage

Existing scanner tests continue to cover each discovery source. The new planner test combines provider config, settings, and a rig passthrough path after --, preserving the #7184 class of path translation through a single pre-stage plan.

Manifest declaration schema

agent_runtimes[].config_path_fields is an optional array of dotted selectors, with [] and * support for arrays/maps. It is additive: manifests without declarations retain existing behavior.

Verification

  • cargo build -j 3
  • cargo test -j 3 planner_combines_provider_settings_and_rig_passthrough_inputs_before_staging
  • cargo test -j 3 declared_config_path_field_is_validated_without_core_key_knowledge
  • cargo test -j 3 extension_manifest_parses_declared_provider_config_path_fields
  • cargo test -j 3 runner_execution_record
  • cargo clippy --all-targets -j 3 2>&1 | tail -20 (existing warnings only; no new warnings)

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenAI GPT-5.6 (terra) via opencode, orchestrated by Claude (claude-fable-5)
  • Used for: Planner consolidation design and implementation, plus verification runs. Reviewed by Chris Huber.

@homeboy-ci

homeboy-ci Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Homeboy Results — homeboy

Lint

review lint — passed

ℹ️ Full options: homeboy self docs commands/lint
ℹ️ Save lint baseline: homeboy review lint homeboy --baseline
Deep dive: homeboy review lint homeboy --changed-since d1f85bf

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-homeboy-review-lint-homeboy-Linux contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-homeboy-review-lint-homeboy-Linux contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/homeboy/actions/runs/29213684234

Audit

review audit — passed

  • structural — 46 finding(s)
  • field_patterns — 17 finding(s)
  • core_boundary_leak:core-agnostic-source — 16 finding(s)
  • intra-method-duplication — 8 finding(s)
  • dead_code — 5 finding(s)
  • test_quality — 5 finding(s)
  • Types — 3 finding(s)
  • near-duplication — 3 finding(s)
  • docs — 2 finding(s)
  • command_status_contracts — 1 finding(s)
  • Total: 107 finding(s)

Deep dive: homeboy review audit homeboy --changed-since d1f85bf

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-homeboy-review-audit-homeboy-Linux contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-homeboy-review-audit-homeboy-Linux contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/homeboy/actions/runs/29213684234
Tooling versions
  • Homeboy CLI: homeboy 0.281.20+9904fb636949-dirty+9904fb636
  • Extension: rust from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: 79dd370c
  • Action: unknown@unknown

@chubes4
chubes4 merged commit a88c671 into main Jul 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

consolidate path-bearing input discovery into one PathMaterializationPlanner; always persist RunnerExecutionRecord at planned/running/terminal

1 participant