refactor: plan Lab path materialization - #7853
Merged
Merged
Conversation
Contributor
Homeboy Results —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PathMaterializationPlanner, evaluated before remote workspace mutation and consumed once by workspace staging.config_path_fieldsdeclarations to extension agent-runtime manifests and carry them into the runtime catalog; provider-config validation honors declared fields.RunnerExecutionRecordtransition snapshots for daemon and reverse-broker planned, running, and terminal states, including job watch/follow/cancel actions.Diffstat
Fixes #7705
Planner design
The planner resolves workspace refs and aggregates provider configuration, agent-task plans and fanout, runtime components, settings, rig-declared passthrough inputs, refresh/extension sources, overlays, and rig component environment paths before staging. Workspace staging consumes its resolved argv and workspace list, eliminating the former post-remap path-setting re-scan.
Parity coverage
Existing scanner tests continue to cover each discovery source. The new planner test combines provider config, settings, and a rig passthrough path after
--, preserving the #7184 class of path translation through a single pre-stage plan.Manifest declaration schema
agent_runtimes[].config_path_fieldsis an optional array of dotted selectors, with[]and*support for arrays/maps. It is additive: manifests without declarations retain existing behavior.Verification
cargo build -j 3cargo test -j 3 planner_combines_provider_settings_and_rig_passthrough_inputs_before_stagingcargo test -j 3 declared_config_path_field_is_validated_without_core_key_knowledgecargo test -j 3 extension_manifest_parses_declared_provider_config_path_fieldscargo test -j 3 runner_execution_recordcargo clippy --all-targets -j 3 2>&1 | tail -20(existing warnings only; no new warnings)AI assistance