refactor: extract process and finding types into dedicated crates - #8166
Merged
Conversation
Extracts two pristine leaf modules into path-only crates:
- homeboy-process (455 LOC, 20 importers): process spawn/signal/lifecycle
helpers; depends only on homeboy-error + libc + ctrlc.
- homeboy-finding (381 LOC, 22 importers): structured finding/diagnostic types
for audit and review output; serde only.
Both re-exported via core/mod.rs so crate::core::{process,finding}::* call
sites are unchanged. Not published to crates.io; still ships as the single
homeboy binary. cargo check --lib passes; both crates' unit tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sixth step in the homeboy workspace split. Extracts two pristine leaf modules into path-only crates in one batch (they're independent):
homeboy-error+libc+ctrlc.No crates.io. Path-only members; still ships as the single
homeboybinary.What changed
crates/.src/core/process.rsandsrc/core/finding.rsmoved viagit mv(100% renames).core/mod.rsre-exports both — all ~42 combined call sites unchanged.Verification
cargo check -p homeboy-process -p homeboy-finding— passes.cargo check --lib— passes, 0 errors.cargo teston both crates — 10/10 pass.Progress + next
Crates now:
redaction,error,engine-primitives,product-identity,output,process,finding(7). Next I'm taking on the deferredpaths⇄defaultsdependency cycle as a dedicated inversion PR — it's on the critical path to the bigrunnerextraction and the clean-leaf supply is thinning.🤖 Generated with Claude Code