Fix Lab cook timeout and provider rotation propagation - #8168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Honor the declared timeout, provider rotation, and workspace mapping contract for Lab-offloaded agent-task cooks.
What changed
How to test
cargo test --locked plan_timeout_reaches_each_rotated_provider_attempt --lib; expect passes.cargo test --locked resolved_rotation_can_define_the_initial_provider_attempt --lib; expect passes.cargo test --locked lab_source_path_uses_agent_task_dispatch_workspace --lib; expect passes.cargo test --locked rewrite_remaps_agent_task_workspace_path --lib; expect passes.cargo test --locked timeout_mirrors_remote_job_without_cancelling --lib; expect passes.cargo check --locked --all-targets; expect passes.Compatibility
Legacy non-Lab rotations remain fallback-based. Lab controller-resolved policies now execute the exact declared entries, and both --cwd and --workspace retain their documented behavior.
Evidence
AI assistance
Source relationships