feat: default to imprecise metrics and provide option to enable them#352
Merged
Conversation
F1bonacc1
reviewed
Jul 5, 2025
F1bonacc1
left a comment
F1bonacc1
left a comment
Owner
There was a problem hiding this comment.
Thank you for the PR @jcmuller!
The code looks good, and I don't have any issues with it.
There are 2 things that I would like to ask you to change:
- Make it the default behavior, I think that the impact of recursive measuring was mostly negative, and I would like to make it an opt-in rather than the default.
- Can we rename it from
badto something likewithRecursiveMetrics(default false)?
WDYT?
Contributor
Author
|
Done and done! I have left a second commit renaming it, but can rebase it out of existance. |
F1bonacc1
approved these changes
Jul 5, 2025
F1bonacc1
left a comment
F1bonacc1
left a comment
Owner
There was a problem hiding this comment.
Looks great! Thanks!
Please squash, and it's ready to merge.
jcmuller
changed the title
Contributor
Author
|
Done! |
Signed-off-by: Juan C. Müller <me@juancmuller.com>
|
Owner
|
Awesome! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the projects I am using process compose with have upwards of 10 processes. Having each instance of process compose take about 1 CPU just for management isn't scalable, alas, since I need to have 2 or 3 projects running concurrently for development. This PR makes optional being able to disable the accurate metrics gathering.
resolve #341