feat(api): namespace wide disable/enable/stop/delete/update/ready operations on processes#385
feat(api): namespace wide disable/enable/stop/delete/update/ready operations on processes#385dzmitry-lahoda wants to merge 2 commits into
Conversation
|
As for testing, I will do Rust CLI and write Rust tests in our project. If any issues will return with PR. |
|
@F1bonacc1 I do not think it can be merged, so some design could be discussed? Why something like this to be in Process Compose.
|
F1bonacc1
left a comment
There was a problem hiding this comment.
I think this is a good idea.
This make NSs a more important concept in the PC than it is today.
Thanks for the initiative.
I left you a few comments about the implementation.
Most of them are related to the business logic being implemented in the API instead of the project runnner.
Can you please also add some tests? I am not sure that there won't be any race issues. Check with make testrace.
Yeah, people can add more things too later. For example TUI grouping or depends_on namespace or like.
Ok will do tests. |
|
@F1bonacc1 are tests for such changes usually written on api level or on project runner level? |
e707b22 to
b7a311a
Compare
|
As of now "testing" on API(OpenAPI) level via Rust in our test runner codebase. Will send some patches if any after. |
Project runner level. See |
|
|
need to add namespace ready after #396, so that I can make test(test = namespace) setup wait ready |
|
impl of not ready or other can be decided by client (handling status code + state + config). |
|



I did not moved mutex from per process to per "namespace". So should I? Currently we accept concurrency to some degree. We could improve concurrency by non erroring idempotent (delete deleted), but seems current code will need a lot of refactor.
Also there is no good split for 5xx vs 4xx errors - because low level code does not do it nor other APIs.
For me both acceptable, but imho there should be task to make errors more structured as go can later for whole API.
Add to API only, it is up to later PR make it CLI/ Go client if deemed useful, so better to be do correct errors first.
Let settle semantics first in API to keep PR smallest possible.