(not merge this until at least Monday)add another switch to control #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niklaus-xie
changed the title
if getting db members or not. Need to set to True if SY does not modify at last.
Niklaus-xie
force-pushed
the
h3c-pike-if-sy-not-modify
branch
from
7124133 to
55566f0
Compare
zhaoqin-github
suggested changes
Nov 13, 2020
zhaoqin-github
left a comment
zhaoqin-github
left a comment
There was a problem hiding this comment.
Besides batch adding, other operation also need to call this method. This config option will disable the optimization of all others.
If batch adding need it unique way to append member, it can write its own function and pass it via kwargs.
zhaoqin-github
suggested changes
Nov 13, 2020
zhaoqin-github
left a comment
zhaoqin-github
left a comment
There was a problem hiding this comment.
Another problem is that batch adding is never optimized, so that its service payload will include all listeners and all pools and member under the lb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.