Unit tests #6
Unit tests #6
Conversation
|
|
||
|
|
||
| class TestUnitls(unittest.TestCase): | ||
| def test_create_logging_instance(self): |
There was a problem hiding this comment.
to me, this test is not sufficient. The create logging function is to write logs, which has not been tested.
Proposed:
- write something to the file
- read the file (filename could be worked out)
- check the content
Not sure whether it is the right version of having to_file option though
| } | ||
| }, | ||
| ] | ||
| self.assertEqual(utils.get_number_of_published_papers(data)['yes'], 2) |
There was a problem hiding this comment.
personal choice:
assertDictEqual which indicates clearly that a dict is expected
expected = {
'yes': 2,
'no': 2
}
self.assertDictEqual(utils.get_number_of_published_papers(data),expected)
applies to all other methods
| logger.error(f"Error when try to insert into index {es_index_prefix}{doc_type}: " + str(e.args)) | ||
| pprint.pprint(body) | ||
|
|
||
|
|
There was a problem hiding this comment.
the commit message is not suitable for the changes
Actually could be merged to the next commit
|
General suggestion:
|
First part of unit and integration tests