Skip to content

Unnecessary passing around of req/res #48

Description

@finnhodgkin

A fair few of the functions in your application aren't making use of the arguments you give them.

Examples include:

handleAuth - doesn't need res
handleBuy - doesn't need req
handleCart - doesn't need req, but may do once you change the username to not be hard coded...
handleError - doesn't need req

It's not a big deal and gives you more room to change functionality later, but still worth considering.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions