-
Notifications
You must be signed in to change notification settings - Fork 7
Maps feature updated #1429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Maps feature updated #1429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st merged to test precision. Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
…ng on zoom in Signed-off-by: Ranisa Gupta <[email protected]>
…ng on zoom in Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
…location tracking. prep for mobile app testing via grok Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
…working now Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Ranisa Gupta <[email protected]>
Signed-off-by: Steve Cassidy <[email protected]>
Signed-off-by: Steve Cassidy <[email protected]>
stevecassidy
approved these changes
Apr 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
BSS-799
BSS-801
BSS-739 - will add a separate quick pr for this after discussion with steve.
ngrok local testing:
One of the way to test it locally that I tried is ngrok to forward ports for /app 3000 and api 8080
Worked but didn't quite smoohtly. :-(
npm install -g ngrok
My auth code - not adding here: ngrok config add-authtoken <your_token_here>
yaml for both: worked well in mobile phone individually
version: "2"
authtoken: <your_token_here>
handle redirect 3001
tunnels:
frontend:
addr: 3000
proto: http
backend:
addr: 8080
proto: http
update env files for /app, /api
Description
This PR enhances the Map component by:
Implemented a, real-time GPS location cursor:
A blue dot for user position
A rotating directional triangle for heading
A pulsing accuracy circle
Changes related to live gps cursor in real-time, there should be a map cursor pointing as per user's location
The ability to save and clear the selected point has been enhanced and more intuitive , pin location has been added replacing the green dot that was previously used to save point.
Note: Real GPS and fake GPS modes are mutually exclusive
Added support for browser-based testing via window.USE_FAKE_GPS = true: (Won't wokr if some silent issue in maps are there)
Simulates location updates using a circular path
Useful for desktop testing without mobile hardware
Commented the redundant marker like "Here" purple dot
Added a proper cleanup of previous layers/watchers on mount/unmount.
How to Test
Real GPS (Mobile or Secure Context):
Deploy or run the app in a mobile environment (or browser with HTTPS).
Open the map and grant location permissions.
Verify:
A blue dot with accuracy circle and directional triangle appears.
Cursor updates in real-time as you move.
You can select a pin and still see the live GPS cursor afterward.
You can clear the pin, and the live cursor remains.
Fake GPS Mode (Desktop browser testing):
Open DevTools console and run this before loading the map:
Copy -> window.USE_FAKE_GPS = true;
Reload the map page/component and test if it works in map
PLEASE NOTE FAKE GPS WON'T WORK IF THERE'S ANY ISSUE IN MAP OR ANY SILENT ISSUE. But added it for best case scenario.
To disable fake GPS, refresh the page and do not set the global flag.
Checklist