chore: Remove default helper text, make certainty and annotation false by default #1449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Kontos <[email protected]>
Signed-off-by: Ryan Kontos <[email protected]>
Signed-off-by: Ryan Kontos <[email protected]>
PeterBaker0
approved these changes
Apr 16, 2025
There was a problem hiding this comment.
Looks fine - but you don't need to remove instances of helper text from the sample notebooks + mocks. Just the default field instantiations + the ui spec reducer which adds the annotations. If you're confident with that update based on this comment + you have tested it, feel free to merge
There was a problem hiding this comment.
can you revert changes to sample notebooks - they can have helper text in them
designer/src/test-notebook.ts
Outdated
…remove-default-help-uncheck-certainty-annotation Signed-off-by: Ryan Kontos <[email protected]>
|
@PeterBaker0 Thanks for the approval, I am just unable to merge with main as I do not have authorisation! |
…remove-default-help-uncheck-certainty-annotation Signed-off-by: Ryan Kontos <[email protected]>
…ty-annotation Signed-off-by: Peter Baker <[email protected]>
Signed-off-by: Peter Baker <[email protected]>
Signed-off-by: Peter Baker <[email protected]>
PeterBaker0
deleted the
chore/ui-remove-default-help-uncheck-certainty-annotation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: Remove default helper text, make certainty and annotation false by default
JIRA Ticket
BSS-885
Description
Some minor improvements to Designer.
Proposed Changes
How to Test
Checklist