fix: optional key configuration push for npm run migrate #1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s where keys are already managed natively Signed-off-by: Peter Baker <[email protected]>
Signed-off-by: Peter Baker <[email protected]>
stevecassidy
approved these changes
Apr 24, 2025
| ); | ||
|
|
||
| // Run database initialization and migration with force and pushKeys parameters | ||
| await initialiseAndMigrateDBs({ |
There was a problem hiding this comment.
This is only called in one place and force is set to true, is there any need to retain this any more? Do we ever want to not overwrite old design documents now?
There was a problem hiding this comment.
let's defer this as out of scope for this fix - but good point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the application of key configuration from the local .env into the deployment an opt in --keys flag rather than default behaviour. The reason for this is that in deployed prod environments, it is hard or even impossible for the local environment to match the key configuration of the deployed environment, and migration is really about database migration in this context.