Skip to content

Conversation

@PeterC-DLS
Copy link

This extends NXmpes and adds some new groups and fields and also adjusts some existing fields' classes.

NB this is a rebase of #65

Copy link
Collaborator

@lukaspie lukaspie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PeterC-DLS I would like to come back to this proposal at some point. We also have some PEEM users in FAIRmat and it would be helpful to offer such a description to them as well.

I think what you suggested is already very reasonable, we just need to adjust to the latest developments.

My suggestion would be that we adjust the definition a bit to fit to the current NeXus standard and then we add this definition as a contributed one in the NIAC repo. Then we still don't have it completely fixed and if there is more feedback from the community going forward, we can still adjust a bit. What do you think?

@PeterC-DLS
Copy link
Author

I will re-examine the recently merged NXmpes, rebase this PR and check with our beamline staff and others on updating the commented fields.

@lukaspie
Copy link
Collaborator

lukaspie commented Aug 7, 2025

I will re-examine the recently merged NXmpes, rebase this PR and check with our beamline staff and others on updating the commented fields.

Perfect thanks! I will also try to gather some feedback from our users.

cc @rettigl

@PeterC-DLS PeterC-DLS force-pushed the mpes-peem branch 2 times, most recently from 66bdd41 to d5e0b26 Compare August 11, 2025 13:37
PeterC-DLS and others added 5 commits November 11, 2025 17:17
This extends NXmpes and adds some new groups and fields and also adjusts some existing fields' classes
Move YAML to nyaml directory, tweak PEEM definition according to feedback, and add some units
Fix some indentations, switch to unit, add an NXsource for PEEM case, and
rename coordinate_system_set to geometries
Push an electron gun to NXmpes, clarify that external links are to fields in external files,
fix flux, rename items as raw_data and sample_bias_potentiostat
Also, state that an associated_beam can be the name of an NXbeam group
in the enclosing instrument group.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants