-
Notifications
You must be signed in to change notification settings - Fork 9
Add new application definition for PEEM experiments #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: fairmat
Are you sure you want to change the base?
Conversation
lukaspie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PeterC-DLS I would like to come back to this proposal at some point. We also have some PEEM users in FAIRmat and it would be helpful to offer such a description to them as well.
I think what you suggested is already very reasonable, we just need to adjust to the latest developments.
My suggestion would be that we adjust the definition a bit to fit to the current NeXus standard and then we add this definition as a contributed one in the NIAC repo. Then we still don't have it completely fixed and if there is more feedback from the community going forward, we can still adjust a bit. What do you think?
|
I will re-examine the recently merged |
Perfect thanks! I will also try to gather some feedback from our users. cc @rettigl |
66bdd41 to
d5e0b26
Compare
This extends NXmpes and adds some new groups and fields and also adjusts some existing fields' classes
Move YAML to nyaml directory, tweak PEEM definition according to feedback, and add some units
Fix some indentations, switch to unit, add an NXsource for PEEM case, and rename coordinate_system_set to geometries
d9286d5 to
a54fdef
Compare
Push an electron gun to NXmpes, clarify that external links are to fields in external files, fix flux, rename items as raw_data and sample_bias_potentiostat
Also, state that an associated_beam can be the name of an NXbeam group in the enclosing instrument group.
27411c9 to
014011d
Compare
This extends NXmpes and adds some new groups and fields and also adjusts some existing fields' classes.
NB this is a rebase of #65