Add JSON file output option - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for generating JSON files in the export workflow, alongside the existing Parquet and CSV formats. The changes update type definitions, file writing utilities, and consolidation logic to recognize and process JSON files throughout the system.
Support for JSON file format:
OutputFileTypeLiteralinmodels.pyto include'json'as a valid output file type.write_json_fileutility function inutils.pyto write NOMAD entry dictionaries to a JSON file, with validation for file extension.searchactivity inactivities.pyto support JSON as an output format, including relevant error handling and selection of the correct write function. [1] [2]Consolidation logic enhancements:
consolidate_filesutility inutils.pyto allow merging multiple JSON files, in addition to Parquet and CSV, into a single consolidated file.searchandconsolidate_output_filesactivities to reflect support for JSON files. [1] [2]These changes ensure that the workflow can now seamlessly handle JSON files for both output and consolidation tasks.