Skip to content

Split read archive from write tabular - #70

Merged
ka-sarthak merged 5 commits into
mainfrom
split-read-archive-from-write-tabular
Aug 18, 2026
Merged

Split read archive from write tabular#70
ka-sarthak merged 5 commits into
mainfrom
split-read-archive-from-write-tabular

Conversation

@ka-sarthak

@ka-sarthak ka-sarthak commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Splits read_archives_and_write_output_tabular activity into two activities:

  • read_archives_and_write_table_rows: read the archives from Upload and streams one entry at a time into a temporary .ndjson file. Also creates an Arrow schema and serializes it.
  • write_output_tabular: reads the temporary .ndjson and Arrow schema to create parquet/csv output file.

Each activity has their own timeouts decided by config.read_archives_timeout and config.write_tabular_timeout

@coveralls

coveralls commented Aug 18, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 32116623412

Coverage increased (+0.3%) to 82.049%

Details

  • Coverage increased (+0.3%) from the base build.
  • Patch coverage: 15 uncovered changes across 2 files (83 of 98 lines covered, 84.69%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
src/nomad_ml_workflows/actions/export_entries/activities.py 20 6 30.0%
src/nomad_ml_workflows/actions/export_entries/utils.py 35 34 97.14%
Total (5 files) 98 83 84.69%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1337
Covered Lines: 1097
Line Coverage: 82.05%
Coverage Strength: 0.82 hits per line

💛 - Coveralls

@ka-sarthak ka-sarthak self-assigned this Aug 18, 2026
@ka-sarthak
ka-sarthak merged commit 468b9ff into main Aug 18, 2026
2 checks passed
@ka-sarthak
ka-sarthak deleted the split-read-archive-from-write-tabular branch August 18, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants