Skip to content

Apply north#71

Open
RubelMozumder wants to merge 4 commits into
mainfrom
ApplyNorth
Open

Apply north#71
RubelMozumder wants to merge 4 commits into
mainfrom
ApplyNorth

Conversation

@RubelMozumder

Copy link
Copy Markdown
Collaborator

No description provided.

@coveralls

coveralls commented Feb 4, 2026

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 21707055018

Details

  • 8 of 10 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.4%) to 89.474%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/test_nomad_north_tools.py 6 8 75.0%
Totals Coverage Status
Change from base Build 20129629698: -2.4%
Covered Lines: 51
Relevant Lines: 57

💛 - Coveralls

Comment thread src/pynxtools_spm/nomad/north_tools/spm/README.md Outdated
Comment thread .cruft.json Outdated
"reader_class": "SPMReader",
"author_name": "The NOMAD authors",
"author_email": "fairmat@physik.hu-berlin.de",
"github_username": "RubelMozumder",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this is where we set the registry for the container? In that case, this should be FAIRmat-NFDI!

Comment thread tests/data/north_tools/spm/CommandLine.ipynb
Test the image:

```bash
docker run -p 8888:8888 ghcr.io/RubelMozumder/pynxtools-spm:latest

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@RubelMozumder RubelMozumder marked this pull request as ready for review February 5, 2026 10:44
Copilot AI review requested due to automatic review settings February 5, 2026 10:44
@RubelMozumder RubelMozumder removed the request for review from Copilot February 5, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants