Fix: Crash due to use of unfiltered participant list during session TSV creation, blank session.tsv files. - #5
Open
danlurie wants to merge 4 commits into
Open
Fix: Crash due to use of unfiltered participant list during session TSV creation, blank session.tsv files.#5danlurie wants to merge 4 commits into
danlurie wants to merge 4 commits into
Conversation
…rting # of participants downloaded.
Author
|
bump As far as I know, this script will not work properly without this fix. I'm happy to merge the pull request if someone gives me write access again. |
danlurie
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this fix, the script would correctly filter files to download by scan, session, age, etc, but an unfiltered (or incompletely filtered) version of the participant list was used at the end to (re-)create session
tsvfiles. This resulted in a crash when the script attempted to save a session file to a folder for a participant which had not been downloaded.Use of an unfiltered participant list (and unfiltered
participants_df) also resulted in an incorrect number being reported for the number of participants for whom data was downloaded.