Utils/WritePriorityMutex: Support being forkable #5076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be useful to fix the mutex locking mess that occurs currently when forks occur. Instead of needing to be /very/ meticulous with many futexes, we can instead have working threads shared_lock this one, then when a fork occurs just only have the forker themselves unique_lock and let the readers drain out. Since it's write-priority it'll happen quite quickly, letting the fork get in and out relatively easily. This is going to take some massaging to get the frontend and FEXCore to a place that this works but we can get this simple change in early.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be useful to fix the mutex locking mess that occurs currently when forks occur. Instead of needing to be /very/ meticulous with many futexes, we can instead have working threads shared_lock this one, then when a fork occurs just only have the forker themselves unique_lock and let the readers drain out. Since it's write-priority it'll happen quite quickly, letting the fork get in and out relatively easily.
This is going to take some massaging to get the frontend and FEXCore to a place that this works but we can get this simple change in early.