Move mindeps generation logic to separate function

[Shivansh-007]

from resolver.mindeps import get_min_deps

requirements = ['importlib-metadata>=3.2.0', "pytest>=4 ; extra == 'test'", "pytest-cov>=2 ; extra == 'test'"]
min_deps = get_min_deps(requirements)

print(min_deps)

[Shivansh-007]

Can you let me know if there are any updates on this PR, @FFY00? I have been waiting for a while for this functionality to be available in resolver.

[FFY00]

@Shivansh-007 thank you for the contribution, and sorry for the delay 😓

FYI, in the future feel free to ping me as often as you think necessary, as that's helpful for me to not forget there's something blocked on me.

The PR looks good overall, but I have a few comments.

[FFY00]

Let's try to avoid using specific data types unless necessary

Suggested change

	def get_min_deps(
	requirements: List[str],
	reporter: Optional[resolvelib.BaseReporter] = None,
	extras: Optional[Set[str]] = None,
	markers: Optional[Dict[str, str]] = None
	) -> Dict[str, str]:
	def get_min_deps(
	requirements: Collection[str],
	reporter: Optional[resolvelib.BaseReporter] = None,
	extras: Optional[Collection[str]] = None,
	markers: Optional[Mapping[str, str]] = None
	) -> Mapping[str, str]:

[FFY00]

nitpick: I'd prefer to be more explicit here, even if it takes an extra line.

Suggested change

	reporter = reporter or resolvelib.BaseReporter
	if not reporter:
	reporter = resolvelib.BaseReporter

[FFY00]

Is there any particular reason you moved this here? Unless there's a good reason not to, I think we should keep it in resolver.mindeps. Also notice that removing it from there breaks imports, this class is meant to be available for people to use.

[FFY00]

nitpick:

The .copy() call shouldn't be needed here because the | operator does not mutate the set, it creates a new one.

Since extras will always be set now, you could just do extras = extras | {''}. Note that we can't do extras |= {''} because |= does mutate the original set 😅

But anyway, since we are changing the type hint to Collection, we need to rewrite this snippet anyway.

[FFY00]

nitpick: I'd skip the is None, to simplify the condition.

Suggested change

	if markers is not None and any(marker in _MARKER_KEYS for marker in markers):
	if markers and any(marker in _MARKER_KEYS for marker in markers):